| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
tree-sitter-ruby wraps `class C < Base` in a `superclass` node whose child is a `constant` (or `scope_resolution` for `A::B`). collect_bases_from_field matched neither, so the superclass fell through to the raw-text fallback and base_classes stored "< Base" — operator included. A base spelled that way never resolves, so Ruby subclasses produced zero INHERITS edges, and the Rails chain (User < ApplicationRecord < ActiveRecord::Base) never linked up. Accept both node kinds. The accompanying inherit_ruby rows fail 5/5 without this change, each on the "<" substring that is the bug's signature. Refs DeusData#1701 Assisted-by: OpenCode:anthropic/claude-opus-5 Signed-off-by: Ben Fairless <ben@oaf.org.au>
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. 0.9.1-rc.1 is out, so the release freeze that held reviews is over — but it left a large queue of open pull requests behind it, and we are reading through them oldest-first. The background is in discussion #1144. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
Sorry, something went wrong.
test/test-windows-guards test_daemon_stability.py::section_churn_stability failed with 'SETUP FAIL: permanent daemon did not start for the churn check' on the previous run. The failure was immediate (76ms after prior section) with no error output, indicating a transient runner resource issue — not a regression from this PR's changes (extract_defs.c + test_extraction_inheritance.c cannot affect daemon startup). Re-running to confirm. Assisted-by: OpenCode:anthropic/claude-sonnet-4-6 Signed-off-by: Ben Fairless <ben@oaf.org.au>
test_daemon_stability.py::section_crash_recovery failed with 'error: the daemon did not accept the UI configuration; browser was not opened' after a kill-9 recovery on the Windows runner. This is the second distinct Windows daemon stability flake across two runs of this PR (section_churn_stability failed on run 32198834397; section_crash_recovery on run 32334362969 — different sections, same transient pattern). The PR changes are limited to Ruby superclass extraction in extract_defs.c / helpers.c / lang_specs.c and cannot affect daemon startup. Re-running to confirm. Assisted-by: OpenCode:anthropic/claude-sonnet-4-6 Signed-off-by: Ben Fairless <ben@oaf.org.au>
| Back | FazBrowse Home | New Git URL |
What does this PR do?
Slice 1 of 5 splitting #1706, in the order requested in review. This one stands alone and depends on nothing else in the series.
tree-sitter-ruby wraps class C < Base in a superclass node whose child is a constant (or a scope_resolution for A::B). collect_bases_from_field matched neither, so the superclass fell through to the raw-text fallback and base_classes stored "< Base" — operator included. A base spelled that way never resolves, so Ruby subclasses produced zero INHERITS edges and the Rails chain (User < ApplicationRecord < ActiveRecord::Base) never linked up.
The fix adds both node kinds to the allow-list that already carries Python's identifier / attribute.
Reproduce-first. The new inherit_ruby rows in tests/test_extraction_inheritance.c fail 5/5 without the one-line change, each on the "<" substring that is the bug's signature:
Incidental observation, not changed here: inherit_python, inherit_typescript, inherit_tsx, inherit_php and inherit_kotlin all pass now, so the RED: markers on them in SUITE(extraction_inheritance) are stale. Left alone to keep this PR to one thing; happy to file it separately.
Where this sits in the series
Slices 1, 2 and 3 are independent: I verified the resolver in slice 3 passes all its rows with neither extraction fix applied, so they are only stacked where a later slice genuinely needs an earlier one, per the review.
CI baseline
main at 4d7d9f1 is red for reasons unrelated to this change: #1181 gave list_projects pagination parameters, retiring the last empty-properties schema that #1359's guards used as their zero-argument example. cli_zero_argument_tool_never_reads_stdin_issue1359 and cli_stdin_args_gate_tracks_tool_schema_issue1359 fail on every leg. #1704 already fixes it. Until that merges, ci-ok will be red here for that reason.
Refs #1701
Checklist
unsigned commits (DCO, see CONTRIBUTING.md)
Assisted by OpenCode using anthropic/claude-opus-5.