| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
@ronnie-llamado I'm gonna take a deep dive and test this. May take a bit. This looks great. If this works, may ask to make a change to README and CI to remove the version restriction. |
Sorry, something went wrong.
|
@keithrfung I'm looking forward to what you potentially find in the deep dive. I'm still not entirely sure why it works without passing init=False into the dataclass (and when it fails if you do pass it in). Another uncertainity: why did it only take explicitly defining __init__ in for Manifest, InternationalizedText, ContactInformation, and Language? AnnotatedString matches the same pattern (only inherits from CryptoHashable), but did not throw any errors in testing. As far as the other changes: No problem, I'll have the README/CI changes queued up. |
Sorry, something went wrong.
|
@ronnie-llamado It's a creative fix but I believe this works. Add the README and I will be waiting to approve. ✅ I believe AnnotatedString doesn't throw because of the ordering of the elements. AnnotatedString has only optional parameters where all the others have both. I will make an issue to remove these in the future. The README and any other documentation can now say 3.9 instead of a specific version on the changes. |
Sorry, something went wrong.
I had the same thought at one point, but ContactInformation also only has optional parameters. It actually looks like AnnotatedString is not being instantiated in the testing, so no errors are being thrown. When generating ContactInformation, emails are passed in straight from hypothesis and no phone numbers are passed in. These two are expected to be of type AnnotatedString. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Issue
Fixes #440
Description
Testing