Apply explicit __init__ workaround to AnnotatedString - #465
Merged
keithrfung merged 2 commits intoOct 10, 2021
Merged
keithrfung merged 2 commits into
keithrfung merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
keithrfung
self-requested a review
October 10, 2021 14:00
keithrfung
approved these changes
Oct 10, 2021
keithrfung
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Good catch. I'm guessing it ended up being a problem with particular tests. Sneaky AnnotatedString. Thanks for the followup.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #440
Description
Testing
poetry run make test