KMS: Updated for new client library - #1903
Merged
daniel-sanche merged 5 commits intoJan 7, 2019
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
engelke
reviewed
Dec 19, 2018
Comment thread
kms/api-client/asymmetric.py
Outdated
engelke
reviewed
Dec 19, 2018
Comment thread
kms/api-client/asymmetric.py
engelke
reviewed
Dec 19, 2018
Comment thread
kms/api-client/asymmetric.py
engelke
reviewed
Dec 19, 2018
Comment thread
kms/api-client/asymmetric.py
Outdated
engelke
reviewed
Dec 19, 2018
Comment thread
kms/api-client/asymmetric.py
engelke
reviewed
Dec 19, 2018
Comment thread
kms/api-client/asymmetric_test.py
Outdated
engelke
reviewed
Dec 19, 2018
Comment thread
kms/api-client/asymmetric_test.py
Outdated
engelke
reviewed
Dec 19, 2018
Comment thread
kms/api-client/asymmetric_test.py
engelke
reviewed
Dec 19, 2018
Comment thread
kms/api-client/quickstart.py
engelke
reviewed
Dec 19, 2018
Comment thread
kms/api-client/quickstart.py
engelke
reviewed
Dec 19, 2018
Comment thread
kms/api-client/requirements.txt
Outdated
engelke
reviewed
Dec 19, 2018
Comment thread
kms/api-client/asymmetric_test.py
Outdated
engelke
suggested changes
Dec 19, 2018
engelke
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
The asymmetric samples all have comments saying that they work on key IDs, but actually require key version IDs. The tests all work with key versions, so they pass.
Please address the comments and update.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@engelke I addressed your comments, let me know if there's anything else |
Sorry, something went wrong.
engelke
approved these changes
Dec 21, 2018
busunkim96
pushed a commit
to googleapis/python-kms
that referenced
this pull request
Jun 4, 2020
…hon-docs-samples#1903) * updated kms samples to use new gapic client library
8 tasks
rsamborski
pushed a commit
that referenced
this pull request
Nov 8, 2022
rsamborski
pushed a commit
that referenced
this pull request
Nov 11, 2022
rsamborski
pushed a commit
that referenced
this pull request
Nov 14, 2022
dandhlee
pushed a commit
that referenced
this pull request
Nov 14, 2022
parthea
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Oct 21, 2023
…hon-docs-samples#1903) * updated kms samples to use new gapic client library
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated all samples to use the new libraries
tracking bug: b/120216809