dialogflow: use unique names for all resources for tests to avoid col… - #2696
dialogflow: use unique names for all resources for tests to avoid col…#2696nnegrey merged 12 commits into
Conversation
Sorry, something went wrong.
gguuss
left a comment
There was a problem hiding this comment.
Tests are failing do to quota. Maybe something is wrong with the test project.
Sorry, something went wrong.
|
I think the problem is way back when these tests were written they all sorta rely on one machine running them at a time, now with 4 in parallel some of the requests are expecting to list one resource but find multiple and that is one problem. I'm breaking the tests up into individual files and have proper setup teardown rather than rely on them running in order which some do. |
Sorry, something went wrong.
|
Alright looks like I need to request a quota increase, it caps out at 60 requests per minute and with 4 different versions running at once that is quite soon. |
Sorry, something went wrong.
| pytest.KNOWLEDGE_BASE_ID = None | ||
|
|
||
|
|
||
| @pytest.fixture(scope="function", autouse=True) |
There was a problem hiding this comment.
@gguuss, while I wait for the quota increase.
How do you feel about these types of tests?
I was gonna modify the rest and separate them into individual files in different PRs, but the current Knowledge and Document tests were checking that only 1 thing existing, so I at least had to update those for the 4 python versions.
Sorry, something went wrong.
There was a problem hiding this comment.
I'm fine for checking that all the response parameters are there but adding more detailed checks, particularly in ML APIs, can make the checks more brittle. If these are mocks, then it diverges a bit from the spirit of doing integration testing to make sure we see whether our p;roducts are encountering outages or the client libraries are breaking.
Sorry, something went wrong.
gguuss
left a comment
There was a problem hiding this comment.
LGTM.
Sorry, something went wrong.
|
@nnegrey I think you should be able to merge when green, just lmk if you need me to take a look again. |
Sorry, something went wrong.
|
Getting errors about the long running client: AttributeError: module 'google.longrunning.operations_pb2' has no attribute 'OperationsStub' Let me see if something changed in the client or something. |
Sorry, something went wrong.
|
I believe these tests failed cus the old tests ran over night and caused some issues cus they fail on multiple run times of python. |
Sorry, something went wrong.
|
I have a couple PRs ready to fix those oddities, but this one should go first. |
Sorry, something went wrong.
…… [(#2696)](GoogleCloudPlatform/python-docs-samples#2696) * dialogflow: use unique names for all resources for tests to avoid collision * lint: line length * break up knowledge base tests and document tests from one file into individual tests * lint * bump library version * ping googleapis-common-protos to avoid release breakage * Update requirements.txt Co-authored-by: Gus Class <gguuss@gmail.com>
…… [(#2696)](GoogleCloudPlatform/python-docs-samples#2696) * dialogflow: use unique names for all resources for tests to avoid collision * lint: line length * break up knowledge base tests and document tests from one file into individual tests * lint * bump library version * ping googleapis-common-protos to avoid release breakage * Update requirements.txt Co-authored-by: Gus Class <gguuss@gmail.com>
…… [(#2696)](#2696) * dialogflow: use unique names for all resources for tests to avoid collision * lint: line length * break up knowledge base tests and document tests from one file into individual tests * lint * bump library version * ping googleapis-common-protos to avoid release breakage * Update requirements.txt Co-authored-by: Gus Class <gguuss@gmail.com>
…… [(#2696)](#2696) * dialogflow: use unique names for all resources for tests to avoid collision * lint: line length * break up knowledge base tests and document tests from one file into individual tests * lint * bump library version * ping googleapis-common-protos to avoid release breakage * Update requirements.txt Co-authored-by: Gus Class <gguuss@gmail.com>
…… [(#2696)](#2696) * dialogflow: use unique names for all resources for tests to avoid collision * lint: line length * break up knowledge base tests and document tests from one file into individual tests * lint * bump library version * ping googleapis-common-protos to avoid release breakage * Update requirements.txt Co-authored-by: Gus Class <gguuss@gmail.com>
…… [(#2696)](GoogleCloudPlatform/python-docs-samples#2696) * dialogflow: use unique names for all resources for tests to avoid collision * lint: line length * break up knowledge base tests and document tests from one file into individual tests * lint * bump library version * ping googleapis-common-protos to avoid release breakage * Update requirements.txt Co-authored-by: Gus Class <gguuss@gmail.com>
…lision