Handle missing nanos. - #2696
Merged
dhermes merged 1 commit intoNov 7, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
This LGTM but I imagine you'll want @tseaver to look at it as well. |
Sorry, something went wrong.
tseaver
approved these changes
Nov 7, 2016
tseaver
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I'd love to sea a rational analysis on the believed/claimed cost savings for the .0 bytes vs. all the induced cache-miss stuff on both client and server side. I would certainly be vetoing such pseudo-optimizations without real evidence if it were up to me.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
I doubt there is a single person or team responsible. |
Sorry, something went wrong.
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
Handle missing nanos.
vchudnov-g
pushed a commit
that referenced
this pull request
Sep 20, 2023
…… [(#2696)](GoogleCloudPlatform/python-docs-samples#2696) * dialogflow: use unique names for all resources for tests to avoid collision * lint: line length * break up knowledge base tests and document tests from one file into individual tests * lint * bump library version * ping googleapis-common-protos to avoid release breakage * Update requirements.txt Co-authored-by: Gus Class <gguuss@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1783 (comment)