FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Simplify noxfile setup. by kurtisvg · Pull Request #2806 · GoogleCloudPlatform/python-docs-samples · GitHub

/ python-docs-samples Public

Simplify noxfile setup. - #2806

Merged
kurtisvg merged 25 commits into
masterfrom
simple-nox
Apr 2, 2020
ConversationCommits (25)ChecksFiles changed
Merged

Simplify noxfile setup.#2806
kurtisvg merged 25 commits into
masterfrom
simple-nox

Conversation

kurtisvg commented Feb 10, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR simplifies the noxfile setup, causing each project use noxfile.py in the project folder. If no noxfile is found, it will search for a noxfile-template.py in the nearest parent folder and use that instead. This will allow per-project configuration of sample versions (and other tests).

Other things:

  • Tests python 3.6 and 3.7 by default
  • Adds Python 3.8 kokoro build configs (won't be active until job is also updated)
  • Removes the shared testing/requirements.py and added project specific requirements-tests.py instead
  • Configures appengine/standard to only test Python 2.7

kurtisvg requested a review from a team as a code owner February 10, 2020 16:38
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 10, 2020
leahecole mentioned this pull request Feb 10, 2020
Merged
crwilcox reviewed Mar 6, 2020
View reviewed changes
Comment thread noxfile-template.py Outdated

kurtisvg commented Apr 2, 2020

Copy link
Copy Markdown
Contributor Author

Admin Merging - Remaining tests are already marked as flakey.

kurtisvg merged commit 3397e6b into master Apr 2, 2020
kurtisvg deleted the simple-nox branch April 2, 2020 02:11
busunkim96 pushed a commit to googleapis/python-texttospeech that referenced this pull request Apr 9, 2020
Simplify noxfile setup. [(#2806)](GoogleCloudPlatform/python-docs-sam…
efaafc3 
…ples#2806)

* chore(deps): update dependency requests to v2.23.0

* Simplify noxfile and add version control.

* Configure appengine/standard to only test Python 2.7.

* Update Kokokro configs to match noxfile.

* Add requirements-test to each folder.

* Remove Py2 versions from everything execept appengine/standard.

* Remove conftest.py.

* Remove appengine/standard/conftest.py

* Remove 'no-sucess-flaky-report' from pytest.ini.

* Add GAE SDK back to appengine/standard tests.

* Fix typo.

* Roll pytest to python 2 version.

* Add a bunch of testing requirements.

* Remove typo.

* Add appengine lib directory back in.

* Add some additional requirements.

* Fix issue with flake8 args.

* Even more requirements.

* Readd appengine conftest.py.

* Add a few more requirements.

* Even more Appengine requirements.

* Add webtest for appengine/standard/mailgun.

* Add some additional requirements.

* Add workaround for issue with mailjet-rest.

* Add responses for appengine/standard/mailjet.

Co-authored-by: Renovate Bot <bot@renovateapp.com>
busunkim96 pushed a commit to googleapis/python-texttospeech that referenced this pull request May 13, 2020
Simplify noxfile setup. [(#2806)](GoogleCloudPlatform/python-docs-sam…
3babc58 
…ples#2806)

* chore(deps): update dependency requests to v2.23.0

* Simplify noxfile and add version control.

* Configure appengine/standard to only test Python 2.7.

* Update Kokokro configs to match noxfile.

* Add requirements-test to each folder.

* Remove Py2 versions from everything execept appengine/standard.

* Remove conftest.py.

* Remove appengine/standard/conftest.py

* Remove 'no-sucess-flaky-report' from pytest.ini.

* Add GAE SDK back to appengine/standard tests.

* Fix typo.

* Roll pytest to python 2 version.

* Add a bunch of testing requirements.

* Remove typo.

* Add appengine lib directory back in.

* Add some additional requirements.

* Fix issue with flake8 args.

* Even more requirements.

* Readd appengine conftest.py.

* Add a few more requirements.

* Even more Appengine requirements.

* Add webtest for appengine/standard/mailgun.

* Add some additional requirements.

* Add workaround for issue with mailjet-rest.

* Add responses for appengine/standard/mailjet.

Co-authored-by: Renovate Bot <bot@renovateapp.com>
busunkim96 pushed a commit to googleapis/python-texttospeech that referenced this pull request May 13, 2020
Simplify noxfile setup. [(#2806)](GoogleCloudPlatform/python-docs-sam…
dc3b715 
…ples#2806)

* chore(deps): update dependency requests to v2.23.0

* Simplify noxfile and add version control.

* Configure appengine/standard to only test Python 2.7.

* Update Kokokro configs to match noxfile.

* Add requirements-test to each folder.

* Remove Py2 versions from everything execept appengine/standard.

* Remove conftest.py.

* Remove appengine/standard/conftest.py

* Remove 'no-sucess-flaky-report' from pytest.ini.

* Add GAE SDK back to appengine/standard tests.

* Fix typo.

* Roll pytest to python 2 version.

* Add a bunch of testing requirements.

* Remove typo.

* Add appengine lib directory back in.

* Add some additional requirements.

* Fix issue with flake8 args.

* Even more requirements.

* Readd appengine conftest.py.

* Add a few more requirements.

* Even more Appengine requirements.

* Add webtest for appengine/standard/mailgun.

* Add some additional requirements.

* Add workaround for issue with mailjet-rest.

* Add responses for appengine/standard/mailjet.

Co-authored-by: Renovate Bot <bot@renovateapp.com>
busunkim96 pushed a commit to googleapis/python-texttospeech that referenced this pull request May 13, 2020
Simplify noxfile setup. [(#2806)](GoogleCloudPlatform/python-docs-sam…
25a9af0 
…ples#2806)

* chore(deps): update dependency requests to v2.23.0

* Simplify noxfile and add version control.

* Configure appengine/standard to only test Python 2.7.

* Update Kokokro configs to match noxfile.

* Add requirements-test to each folder.

* Remove Py2 versions from everything execept appengine/standard.

* Remove conftest.py.

* Remove appengine/standard/conftest.py

* Remove 'no-sucess-flaky-report' from pytest.ini.

* Add GAE SDK back to appengine/standard tests.

* Fix typo.

* Roll pytest to python 2 version.

* Add a bunch of testing requirements.

* Remove typo.

* Add appengine lib directory back in.

* Add some additional requirements.

* Fix issue with flake8 args.

* Even more requirements.

* Readd appengine conftest.py.

* Add a few more requirements.

* Even more Appengine requirements.

* Add webtest for appengine/standard/mailgun.

* Add some additional requirements.

* Add workaround for issue with mailjet-rest.

* Add responses for appengine/standard/mailjet.

Co-authored-by: Renovate Bot <bot@renovateapp.com>
busunkim96 pushed a commit to busunkim96/python-videointelligence that referenced this pull request May 19, 2020
Simplify noxfile setup. [(#2806)](GoogleCloudPlatform/python-docs-sam…
8207cfd 
…ples#2806)

* chore(deps): update dependency requests to v2.23.0

* Simplify noxfile and add version control.

* Configure appengine/standard to only test Python 2.7.

* Update Kokokro configs to match noxfile.

* Add requirements-test to each folder.

* Remove Py2 versions from everything execept appengine/standard.

* Remove conftest.py.

* Remove appengine/standard/conftest.py

* Remove 'no-sucess-flaky-report' from pytest.ini.

* Add GAE SDK back to appengine/standard tests.

* Fix typo.

* Roll pytest to python 2 version.

* Add a bunch of testing requirements.

* Remove typo.

* Add appengine lib directory back in.

* Add some additional requirements.

* Fix issue with flake8 args.

* Even more requirements.

* Readd appengine conftest.py.

* Add a few more requirements.

* Even more Appengine requirements.

* Add webtest for appengine/standard/mailgun.

* Add some additional requirements.

* Add workaround for issue with mailjet-rest.

* Add responses for appengine/standard/mailjet.

Co-authored-by: Renovate Bot <bot@renovateapp.com>
busunkim96 pushed a commit to busunkim96/python-vision that referenced this pull request May 20, 2020
Simplify noxfile setup. [(#2806)](GoogleCloudPlatform/python-docs-sam…
a33c5b2 
…ples#2806)

* chore(deps): update dependency requests to v2.23.0

* Simplify noxfile and add version control.

* Configure appengine/standard to only test Python 2.7.

* Update Kokokro configs to match noxfile.

* Add requirements-test to each folder.

* Remove Py2 versions from everything execept appengine/standard.

* Remove conftest.py.

* Remove appengine/standard/conftest.py

* Remove 'no-sucess-flaky-report' from pytest.ini.

* Add GAE SDK back to appengine/standard tests.

* Fix typo.

* Roll pytest to python 2 version.

* Add a bunch of testing requirements.

* Remove typo.

* Add appengine lib directory back in.

* Add some additional requirements.

* Fix issue with flake8 args.

* Even more requirements.

* Readd appengine conftest.py.

* Add a few more requirements.

* Even more Appengine requirements.

* Add webtest for appengine/standard/mailgun.

* Add some additional requirements.

* Add workaround for issue with mailjet-rest.

* Add responses for appengine/standard/mailjet.

Co-authored-by: Renovate Bot <bot@renovateapp.com>
busunkim96 pushed a commit to busunkim96/python-language that referenced this pull request May 20, 2020
Simplify noxfile setup. [(#2806)](GoogleCloudPlatform/python-docs-sam…
c5336b3 
…ples#2806)

* chore(deps): update dependency requests to v2.23.0

* Simplify noxfile and add version control.

* Configure appengine/standard to only test Python 2.7.

* Update Kokokro configs to match noxfile.

* Add requirements-test to each folder.

* Remove Py2 versions from everything execept appengine/standard.

* Remove conftest.py.

* Remove appengine/standard/conftest.py

* Remove 'no-sucess-flaky-report' from pytest.ini.

* Add GAE SDK back to appengine/standard tests.

* Fix typo.

* Roll pytest to python 2 version.

* Add a bunch of testing requirements.

* Remove typo.

* Add appengine lib directory back in.

* Add some additional requirements.

* Fix issue with flake8 args.

* Even more requirements.

* Readd appengine conftest.py.

* Add a few more requirements.

* Even more Appengine requirements.

* Add webtest for appengine/standard/mailgun.

* Add some additional requirements.

* Add workaround for issue with mailjet-rest.

* Add responses for appengine/standard/mailjet.

Co-authored-by: Renovate Bot <bot@renovateapp.com>
busunkim96 pushed a commit to busunkim96/python-dlp that referenced this pull request May 20, 2020
Simplify noxfile setup. [(#2806)](GoogleCloudPlatform/python-docs-sam…
0f3b4da 
…ples#2806)

* chore(deps): update dependency requests to v2.23.0

* Simplify noxfile and add version control.

* Configure appengine/standard to only test Python 2.7.

* Update Kokokro configs to match noxfile.

* Add requirements-test to each folder.

* Remove Py2 versions from everything execept appengine/standard.

* Remove conftest.py.

* Remove appengine/standard/conftest.py

* Remove 'no-sucess-flaky-report' from pytest.ini.

* Add GAE SDK back to appengine/standard tests.

* Fix typo.

* Roll pytest to python 2 version.

* Add a bunch of testing requirements.

* Remove typo.

* Add appengine lib directory back in.

* Add some additional requirements.

* Fix issue with flake8 args.

* Even more requirements.

* Readd appengine conftest.py.

* Add a few more requirements.

* Even more Appengine requirements.

* Add webtest for appengine/standard/mailgun.

* Add some additional requirements.

* Add workaround for issue with mailjet-rest.

* Add responses for appengine/standard/mailjet.

Co-authored-by: Renovate Bot <bot@renovateapp.com>
busunkim96 pushed a commit to busunkim96/python-videointelligence that referenced this pull request May 20, 2020
Simplify noxfile setup. [(#2806)](GoogleCloudPlatform/python-docs-sam…
e5eb95e 
…ples#2806)

* chore(deps): update dependency requests to v2.23.0

* Simplify noxfile and add version control.

* Configure appengine/standard to only test Python 2.7.

* Update Kokokro configs to match noxfile.

* Add requirements-test to each folder.

* Remove Py2 versions from everything execept appengine/standard.

* Remove conftest.py.

* Remove appengine/standard/conftest.py

* Remove 'no-sucess-flaky-report' from pytest.ini.

* Add GAE SDK back to appengine/standard tests.

* Fix typo.

* Roll pytest to python 2 version.

* Add a bunch of testing requirements.

* Remove typo.

* Add appengine lib directory back in.

* Add some additional requirements.

* Fix issue with flake8 args.

* Even more requirements.

* Readd appengine conftest.py.

* Add a few more requirements.

* Even more Appengine requirements.

* Add webtest for appengine/standard/mailgun.

* Add some additional requirements.

* Add workaround for issue with mailjet-rest.

* Add responses for appengine/standard/mailjet.

Co-authored-by: Renovate Bot <bot@renovateapp.com>
busunkim96 pushed a commit to busunkim96/python-videointelligence that referenced this pull request May 20, 2020
Simplify noxfile setup. [(#2806)](GoogleCloudPlatform/python-docs-sam…
d21146e 
…ples#2806)

* chore(deps): update dependency requests to v2.23.0

* Simplify noxfile and add version control.

* Configure appengine/standard to only test Python 2.7.

* Update Kokokro configs to match noxfile.

* Add requirements-test to each folder.

* Remove Py2 versions from everything execept appengine/standard.

* Remove conftest.py.

* Remove appengine/standard/conftest.py

* Remove 'no-sucess-flaky-report' from pytest.ini.

* Add GAE SDK back to appengine/standard tests.

* Fix typo.

* Roll pytest to python 2 version.

* Add a bunch of testing requirements.

* Remove typo.

* Add appengine lib directory back in.

* Add some additional requirements.

* Fix issue with flake8 args.

* Even more requirements.

* Readd appengine conftest.py.

* Add a few more requirements.

* Even more Appengine requirements.

* Add webtest for appengine/standard/mailgun.

* Add some additional requirements.

* Add workaround for issue with mailjet-rest.

* Add responses for appengine/standard/mailjet.

Co-authored-by: Renovate Bot <bot@renovateapp.com>
rsamborski mentioned this pull request Nov 8, 2022
Merged
8 tasks
This was referenced Nov 10, 2022
Merged
Merged
telpirion mentioned this pull request Nov 16, 2022
Merged
8 tasks
arbrown mentioned this pull request Nov 17, 2022
Merged
8 tasks
msampathkumar mentioned this pull request Nov 18, 2022
Merged
8 tasks
m-strzelczyk mentioned this pull request Nov 18, 2022
Merged
8 tasks
This was referenced Jan 13, 2023
Merged
Closed
yil532 mentioned this pull request Feb 1, 2023
Merged
8 tasks
MiaCY mentioned this pull request Apr 11, 2023
Merged
8 tasks
dizcology mentioned this pull request Jun 16, 2023
Merged
9 tasks
dizcology mentioned this pull request Sep 11, 2023
Merged
9 tasks
Linchin mentioned this pull request Aug 18, 2025
Merged
9 tasks
chalmerlowe mentioned this pull request Feb 19, 2026
Merged
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

noerog noerog left review comments
leahecole leahecole approved these changes
gguuss Awaiting requested review from gguuss
+2 more reviewers
crwilcox crwilcox left review comments
busunkim96 busunkim96 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

busunkim96

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL