FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update Bigtable samples to v2. by tswast · Pull Request #392 · GoogleCloudPlatform/python-docs-samples · GitHub

/ python-docs-samples Public

Update Bigtable samples to v2. - #392

Merged
tswast merged 1 commit into
masterfrom
tswast-bigtable-v2
Jun 29, 2016
ConversationCommits (1)ChecksFiles changed
Merged

Update Bigtable samples to v2.#392
tswast merged 1 commit into
masterfrom
tswast-bigtable-v2

Conversation

tswast commented Jun 29, 2016

Copy link
Copy Markdown
Contributor

Table of Contents generated with:

doctoc --title '**Table of Contents**' bigtable

Needs to wait for next gcloud-python launch so that googleapis/google-cloud-python#1932 can go in. Tested locally on the bigtable-v2 branch of gcloud-python with a
previous version of grpcio.

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 29, 2016
tswast force-pushed the tswast-bigtable-v2 branch from eb39be2 to 7d27bd3 Compare June 29, 2016 19:34
tswast changed the title Update Bigtable samples to v2. Update Bigtable samples to v2. [DO NOT MERGE] Jun 29, 2016

theacodes commented Jun 29, 2016

Copy link
Copy Markdown
Contributor

I think I've mentioned this elsewhere, but the READMEs in this repository mostly just link back to the docs. I don't like the idea of having duplicate instructions here.

theacodes commented Jun 29, 2016

Copy link
Copy Markdown
Contributor

This LGTM once everything is ready. Feel free to merge.

tswast commented Jun 29, 2016

Copy link
Copy Markdown
Contributor Author

These instructions aren't duplicate. The docs contain no download or set up instructions, only code explanation.

I'm waiting on googleapis/google-cloud-python#1940 before merging.

mbrukman commented Jun 29, 2016

Copy link
Copy Markdown
Contributor

googleapis/google-cloud-python#1940 has been merged so you're all set.

Update Bigtable samples to v2.
a981dcd 
Table of Contents generated with:

    doctoc --title '**Table of Contents**' bigtable

Needs to wait for next gcloud-python launch. Tested locally with a
previous version of grpcio.
tswast force-pushed the tswast-bigtable-v2 branch from 7d27bd3 to a981dcd Compare June 29, 2016 23:25
tswast changed the title Update Bigtable samples to v2. [DO NOT MERGE] Update Bigtable samples to v2. Jun 29, 2016

theacodes commented Jun 29, 2016

Copy link
Copy Markdown
Contributor

The docs contain no download or set up instructions, only code explanation.

Uh, are you saying that in order for a user to use these samples they need to read both the docs and this readme? That seems wrong.

tswast commented Jun 29, 2016

Copy link
Copy Markdown
Contributor Author

That seems wrong.

Seemed wrong to me, too. I got some push-back from the tech writers when I tried to add this info to the docs.

Basically, Google punishes sites for having duplicate content. https://support.google.com/webmasters/answer/66359?hl=en
So this is a compromise. Docs can explain and if they want to run, they go to the README.

I just forwarded a thread to the group that has more context.

theacodes commented Jun 29, 2016

Copy link
Copy Markdown
Contributor

Cool, let's resolve it there. The readme here can stay.

tswast merged commit 2fa20c0 into master Jun 29, 2016
tswast deleted the tswast-bigtable-v2 branch June 29, 2016 23:50
nicain pushed a commit that referenced this pull request Nov 2, 2022
chore(deps): update dependency pytest to v7.2.0 (#392)
347b2d4
nicain mentioned this pull request Nov 2, 2022
Closed
8 tasks
donmccasland pushed a commit that referenced this pull request Nov 11, 2022
chore(deps): update dependency google-cloud-securitycenter to v1.16.0 (…
1c4e4ec 
…#392)
donmccasland mentioned this pull request Nov 11, 2022
Merged
8 tasks
telpirion mentioned this pull request Nov 16, 2022
Merged
8 tasks
telpirion pushed a commit that referenced this pull request Nov 16, 2022
chore(deps): update dependency google-cloud-translate to v3.7.3 (#392)
bdecaf4
dandhlee pushed a commit that referenced this pull request Nov 18, 2022
chore(deps): update dependency google-cloud-translate to v3.7.3 (#392)
43c5ba2
holtskinner pushed a commit that referenced this pull request Jan 3, 2023
chore(deps): update dependency pytest to v7.2.0 (#392)
6dc4b94
holtskinner mentioned this pull request Jan 4, 2023
Merged
8 tasks
holtskinner pushed a commit that referenced this pull request Jan 4, 2023
chore(deps): update dependency pytest to v7.2.0 (#392)
1b9fc12
dandhlee pushed a commit that referenced this pull request Jan 5, 2023
chore(deps): update dependency pytest to v7.2.0 (#392)
04b6148
dandhlee pushed a commit that referenced this pull request Jan 26, 2023
chore(deps): update dependency google-cloud-securitycenter to v1.16.0 (…
6b55049 
…#392)
telpirion pushed a commit that referenced this pull request Mar 13, 2023
chore(deps): update dependency google-cloud-securitycenter to v1.16.0 (…
fa338a1 
…#392)
dizcology pushed a commit that referenced this pull request Sep 11, 2023
chore(deps): update dependency google-cloud-videointelligence to v2.9…
d4fcac7 
….0 (#392)
dizcology mentioned this pull request Sep 11, 2023
Merged
9 tasks
leahecole pushed a commit that referenced this pull request Sep 15, 2023
chore(deps): update dependency google-cloud-videointelligence to v2.9…
1e9718b 
….0 (#392)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

theacodes

waprin

lesv

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL