FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Land Bigtable v2 by tseaver · Pull Request #1932 · googleapis/google-cloud-python · GitHub

Land Bigtable v2 - #1932

Merged
tseaver merged 57 commits into
masterfrom
bigtable-v2
Jun 29, 2016
Merged

Land Bigtable v2#1932
tseaver merged 57 commits into
masterfrom
bigtable-v2

Conversation

tseaver commented Jun 29, 2016

Copy link
Copy Markdown
Contributor

This is the monster. See #1850 (comment) for the PRs which landed on the bigtable-v2 branch.

tseaver added 30 commits June 24, 2016 15:59
Pass the 'PROTOC_CMD' and 'GRPC_PLUGIN' values through from make's
environment to the scripts used to pick apart GRPC-specific code.
Put them in a separate '_generated_v2' subdir, to ease migration.

Attempt to factor generation process for clarity (toward #1482).
It was never actually implemented on the back-end in V1, and has been
dropped altogether in V2.
Indicate their V1 source in their names.

Prepratory to converting to V2 equivalents.
…ints

Alias Bigtable V1 imports / factories / entry point constants.
Note that {Create,Update,Delete}ColumnFamily messages all collapse to
ModifyColumnFamilies.
Update bigtable.column_family to use V2 protos
Assert that the state is 'ROW_IN_PROGRESS', and check that the completed
rows match the expected results.
Verify that completed, non-error rows match expected results after an
invalid chunk testcase.
…ror-cases

Clarify handling of V2 'ReadRowsResponse' error cases
Folds new ReadRowsResponse logic from #1907, #1915 into table row
handling.
Convert non-instance-admin protos to Bigtable V2
In V2, those operations are on the instance.
…tos.

Closes #1928.

This is a better hack for #1482, but we still really want #1384.
…1 protos.

This is a better hack for #1482, but we still really want #1384.

.. code:: python

intances = client.list_intances()

This comment was marked as spam.

This comment was marked as spam.

lesv commented Jun 29, 2016

Copy link
Copy Markdown

@tswast PTAL

lesv commented Jun 29, 2016

Copy link
Copy Markdown

@jonparrott PTAL - could you review this PR - ideally, we'd like to get it published today as part of Bigtable GA.

Comment thread gcloud/bigtable/client.py

* a :class:`Client` owns a :class:`.Cluster`
* a :class:`.Cluster` owns a :class:`Table <gcloud.bigtable.table.Table>`
* a :class:`Client` owns a :class:`.Instance`

This comment was marked as spam.

This comment was marked as spam.

tswast commented Jun 29, 2016

Copy link
Copy Markdown
Contributor

Changes LGTM. I tested with this branch on my Hello World samples, and both ran fine. Thanks!

tseaver commented Jun 29, 2016

Copy link
Copy Markdown
Contributor Author

@dhermes any objections to a merge?

lesv commented Jun 29, 2016

Copy link
Copy Markdown

@tseaver - We've had two pythonistas review. dhermes is away. It's ok to merge.

tseaver merged commit 1a2fa6c into master Jun 29, 2016
tseaver deleted the bigtable-v2 branch June 29, 2016 22:25

lesv commented Jun 29, 2016

Copy link
Copy Markdown

@tseaver Can you let us know the PyPi status -- (ie submit and let us know)

tseaver commented Jun 29, 2016
edited
Loading

Copy link
Copy Markdown
Contributor Author

@lesv 0.17.0 is tagged. Travis will push the release when the tag build is finished.

lesv commented Jun 29, 2016

Copy link
Copy Markdown

@tseaver What about docs?

tseaver commented Jun 29, 2016

Copy link
Copy Markdown
Contributor Author

@lesv RTD already shows the 0.17.0 docs. The github.io docs get updated by the same Travis job that makes the PyPI release.

Copy link
Copy Markdown
Contributor

RTD docs on instances have several misspellings: it says intances instead of instances (missing s) which I thought we addressed during code review. One of the more visible ones is right in the section header.

mbrukman commented Jun 29, 2016
edited
Loading

Copy link
Copy Markdown
Contributor

Also, RTD Bigtable usage docs talk only about clusters, does not mention instances at all.

There's also a possible typo or syntax error on the instance API page, where it says:

[...] object will be returned by create() <gcloud.bigtable.instance.Instance.create>`().

tseaver commented Jun 29, 2016

Copy link
Copy Markdown
Contributor Author

Copy link
Copy Markdown
Contributor

Thank you, @tseaver!! Much appreciated.

parthea added a commit that referenced this pull request Nov 24, 2025
parthea pushed a commit that referenced this pull request Mar 2, 2026
The indentation and leading/trailing newlines made it a little harder than necessary to `filterwarnings` the deprecation warning.

(For instance, for pytest's filterwarnings, you'd need `"ignore:\\s+You are using a Python version 3.8:FutureWarning",`...)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL