| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Pass the 'PROTOC_CMD' and 'GRPC_PLUGIN' values through from make's environment to the scripts used to pick apart GRPC-specific code.
Put them in a separate '_generated_v2' subdir, to ease migration. Attempt to factor generation process for clarity (toward #1482).
It was never actually implemented on the back-end in V1, and has been dropped altogether in V2.
Generate code for Bigtable v2 protobufs
Processes the 'ReadRowsResponse.CellChunk' state machine. Add tests based on JSON acceptance tests: https://github.com/GoogleCloudPlatform/cloud-bigtable-client/blob/master/bigtable-client-core/src/test/resources/com/google/cloud/bigtable/grpc/scanner/v2/read-rows-acceptance-test.json.
Drop 'Table.rename'.
Indicate their V1 source in their names. Prepratory to converting to V2 equivalents.
…logic Add 'ReadRowsResponseV2' wrapper
…ints Alias Bigtable V1 imports / factories / entry point constants.
Note that {Create,Update,Delete}ColumnFamily messages all collapse to
ModifyColumnFamilies.
Update bigtable.column_family to use V2 protos
Assert that the state is 'ROW_IN_PROGRESS', and check that the completed rows match the expected results.
Verify that completed, non-error rows match expected results after an invalid chunk testcase.
…ror-cases Clarify handling of V2 'ReadRowsResponse' error cases
Convert non-instance-admin protos to Bigtable V2
In V2, those operations are on the instance.
Support V2 instance admin
|
|
||
| .. code:: python | ||
|
|
||
| intances = client.list_intances() |
|
@jonparrott PTAL - could you review this PR - ideally, we'd like to get it published today as part of Bigtable GA. |
Sorry, something went wrong.
|
|
||
| * a :class:`Client` owns a :class:`.Cluster` | ||
| * a :class:`.Cluster` owns a :class:`Table <gcloud.bigtable.table.Table>` | ||
| * a :class:`Client` owns a :class:`.Instance` |
|
Changes LGTM. I tested with this branch on my Hello World samples, and both ran fine. Thanks! |
Sorry, something went wrong.
|
@dhermes any objections to a merge? |
Sorry, something went wrong.
|
@tseaver - We've had two pythonistas review. dhermes is away. It's ok to merge. |
Sorry, something went wrong.
|
@tseaver Can you let us know the PyPi status -- (ie submit and let us know) |
Sorry, something went wrong.
|
@lesv 0.17.0 is tagged. Travis will push the release when the tag build is finished. |
Sorry, something went wrong.
|
RTD docs on instances have several misspellings: it says intances instead of instances (missing s) which I thought we addressed during code review. One of the more visible ones is right in the section header. |
Sorry, something went wrong.
|
Also, RTD Bigtable usage docs talk only about clusters, does not mention instances at all. There's also a possible typo or syntax error on the instance API page, where it says:
|
Sorry, something went wrong.
|
PyPI: https://pypi.python.org/pypi/gcloud/0.17.0 |
Sorry, something went wrong.
|
Thank you, @tseaver!! Much appreciated. |
Sorry, something went wrong.
The indentation and leading/trailing newlines made it a little harder than necessary to `filterwarnings` the deprecation warning. (For instance, for pytest's filterwarnings, you'd need `"ignore:\\s+You are using a Python version 3.8:FutureWarning",`...)
| Back | FazBrowse Home | New Git URL |
This is the monster. See #1850 (comment) for the PRs which landed on the bigtable-v2 branch.