FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Implement conversion of Uniform to GeneralQuadratureTable by w1th0utnam3 · Pull Request #49 · InteractiveComputerGraphics/fenris · GitHub

/ fenris Public

Implement conversion of Uniform to GeneralQuadratureTable - #49

Open
w1th0utnam3 wants to merge 5 commits into
InteractiveComputerGraphics:masterfrom
w1th0utnam3:quadrature-api
ConversationCommits (5)ChecksFiles changed
Open

Implement conversion of Uniform to GeneralQuadratureTable#49
w1th0utnam3 wants to merge 5 commits into
InteractiveComputerGraphics:masterfrom
w1th0utnam3:quadrature-api

Conversation

w1th0utnam3 commented Nov 14, 2022

Copy link
Copy Markdown
Member

Implements

  • UniformQuadratureTable::to_general(&self, num_elements)
  • GeneralQuadratureTable::with_data(self, data)

w1th0utnam3 commented Nov 14, 2022

Copy link
Copy Markdown
Member Author

Not sure what happened with CI here, maybe you can manually re-run it @Andlon?

Andlon commented Nov 14, 2022

Copy link
Copy Markdown
Member

Not sure what happened with CI here, maybe you can manually re-run it @Andlon?

Hmm, somehow I can't see anything about the CI at all, not sure what's happened here...

Andlon requested changes Nov 18, 2022
View reviewed changes

Andlon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks, this looks useful! Please see comments.

Some very basic tests would also be nice.

Comment thread src/assembly/local/quadrature_table.rs Outdated
Comment thread src/assembly/local/quadrature_table.rs Outdated
Comment thread src/assembly/local/quadrature_table.rs
Andlon reviewed Nov 21, 2022
View reviewed changes

Andlon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Changes look good, I just still think that with_data_from_fn deserves a simple unit test.

Andlon mentioned this pull request Dec 20, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Andlon Andlon requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL