Fix sci handling - #350
Merged
wipawel merged 3 commits intoNov 14, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Merged
sparchatus
force-pushed
the
fix_sci_handling
branch
from
1311614 to
c24b3b3
Compare
November 11, 2025 15:32
wipawel
reviewed
Nov 13, 2025
Comment thread
arch/x86/ioapic.c
Outdated
Comment thread
arch/x86/ioapic.c
Comment thread
common/acpi.c
Comment thread
common/acpi.c
Outdated
Comment thread
include/acpi_ktf.h
Outdated
- IOAPIC init requires ACPI tables - ACPI subsystem enable requires IOAPIC Hence, we first init ACPI tables, then IOAPIC, then enable ACPI subsystem. Signed-off-by: Sandro Rüegge <rueegges@ethz.ch>
- We need a configure_irq because SCI has special polarity and trigger mode - We need mask_irq to implement ACPICA handler removal Signed-off-by: Sandro Rüegge <rueegges@ethz.ch>
We select an unused interrupt vector. Configure/mask the SCI interrupt in IOAPIC. We send the apic end of interrupt signal. Signed-off-by: Sandro Rüegge <rueegges@ethz.ch>
sparchatus
force-pushed
the
fix_sci_handling
branch
from
c24b3b3 to
389e86d
Compare
November 14, 2025 08:44
wipawel
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix handling of the system control interrupt in KTF. I am a bit unsure about whether the interrupt routine we have is re-entrant. If not, we might run into issues since we could have a re-entry once we send the acpi_EOI signal?