Feat power button - #351
Merged
wipawel merged 3 commits intoNov 25, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
sparchatus
force-pushed
the
feat_power_button
branch
from
2aa4248 to
e98fd0c
Compare
November 11, 2025 15:32
wipawel
requested changes
Nov 13, 2025
Comment thread
include/spinlock.h
Outdated
Comment thread
drivers/power_button.c
Outdated
Comment thread
drivers/power_button.c
Outdated
Comment thread
drivers/power_button.c
Outdated
Comment thread
drivers/power_button.c
Outdated
Comment thread
drivers/power_button.c
minipli-oss
reviewed
Nov 13, 2025
Comment thread
drivers/power_button.c
Outdated
sparchatus
force-pushed
the
feat_power_button
branch
3 times, most recently
from
114c5ad to
405cb93
Compare
November 14, 2025 12:30
Copy link
Copy Markdown
Contributor
Author
|
I have removed the spinlock changes. I have added another commit that adds a struct cpu reference to the percpu variable such that we can assert that the handler is indeed running on the BSP. Not sure if that is needed and it might introduce other issues if there is task migration later on. If sb thinks it is a bad idea, I can just drop that commit again. |
Sorry, something went wrong.
sparchatus
force-pushed
the
feat_power_button
branch
from
405cb93 to
9b2fae1
Compare
November 14, 2025 12:35
minipli-oss
reviewed
Nov 15, 2025
Comment thread
drivers/power_button.c
Outdated
minipli-oss
requested changes
Nov 15, 2025
minipli-oss
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Otherwise LGTM!
Sorry, something went wrong.
Comment thread
include/percpu.h
sparchatus
force-pushed
the
feat_power_button
branch
from
9b2fae1 to
9301e05
Compare
November 24, 2025 10:02
minipli-oss
reviewed
Nov 24, 2025
Comment thread
drivers/power_button.c
Outdated
Driver for ACPI fixed power buttons. It allows overwriting the default handler so the button can be used for custom purposes. One such purpose might be to trigger an experiment to run. Signed-off-by: Sandro Rüegge <rueegges@ethz.ch>
Adding a self reference to the percpu allows checking what CPU some code is currently running on. We use this in pb_set_handler to ensure it runs on the bsp.
Signed-off-by: Sandro Rüegge <rueegges@ethz.ch>
sparchatus
force-pushed
the
feat_power_button
branch
from
9301e05 to
a3441a4
Compare
November 25, 2025 12:42
minipli-oss
approved these changes
Nov 25, 2025
minipli-oss
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM!
Thanks, @sparchatus!
Sorry, something went wrong.
wipawel
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for ACPI fixed power buttons. This is based on #350
I wanted to add the functionality to change the power button handler because it would be useful for triggering experiments for me. This opened up a race condition between the interrupt and the function changing the handler. The interrupt may not wait for a spinlock so I added a try_lock function but I am not very convinced by this approach.