Add a workaround for bpo-37658 - #608
Merged
elprans merged 1 commit intoAug 27, 2020
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
elprans
force-pushed
the
workaround-bpo37658
branch
2 times, most recently
from
278c684 to
3f516c5
Compare
August 16, 2020 00:15
1st1
approved these changes
Aug 18, 2020
Copy link
Copy Markdown
|
Upstream's bug was fixed and merged (python/cpython#21894). |
Sorry, something went wrong.
`asyncio.wait_for()` currently has a bug where it raises a `CancelledError` even when the wrapped awaitable has completed. The upstream fix is in python/cpython#21894. This adds a workaround until the aforementioned PR is merged, backported and released. Co-authored-by: Adam Liddell <git@aliddell.com> Fixes: #467 Fixes: #547 Related: #468 Supersedes: #548
elprans
force-pushed
the
workaround-bpo37658
branch
from
3f516c5 to
2bac166
Compare
August 27, 2020 16:53
Copy link
Copy Markdown
Contributor
|
Could this make it into a patch release, if a minor/major isn't planned any time soon? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Yeah, it's a good time to cut a release, since both Python 3.9 and PostgreSQL 13 have been released recently. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
asyncio.wait_for() currently has a bug where it raises a
CancelledError even when the wrapped awaitable has completed.
The upstream fix is in python/cpython#21894. This adds a workaround
until the aforementioned PR is merged, backported and released.
Co-authored-by: Adam Liddell git@aliddell.com
Fixes: #467
Fixes: #547
Related: #468
Supersedes: #548