bpo-37658: Fix asyncio.wait_for() to respect waited task status - #21894
Merged
1st1 merged 1 commit intoAug 26, 2020
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Currently, if `asyncio.wait_for()` itself is cancelled it will always raise `CancelledError` regardless if the underlying task is still running. This is similar to a race with the timeout, which is handled already.
elprans
added a commit
to MagicStack/asyncpg
that referenced
this pull request
Aug 16, 2020
`asyncio.wait_for()` currently has a bug where it raises a `CancelledError` even when the wrapped awaitable has completed. The upstream fix is in python/cpython#21894. This adds a workaround until the aforementioned PR is merged, backported and released. Fixes: #467 Fixes: #547 Related: #468 Supersedes: #548
elprans
added a commit
to MagicStack/asyncpg
that referenced
this pull request
Aug 16, 2020
`asyncio.wait_for()` currently has a bug where it raises a `CancelledError` even when the wrapped awaitable has completed. The upstream fix is in python/cpython#21894. This adds a workaround until the aforementioned PR is merged, backported and released. Co-authored-by: Adam Liddell <git@aliddell.com> Fixes: #467 Fixes: #547 Related: #468 Supersedes: #548
1st1
approved these changes
Aug 18, 2020
Copy link
Copy Markdown
Member
|
Closed/reopen the pr to hopefully fix unreported Travis status blocking the merge. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
@1st1: Please replace # with GH- in the commit message next time. Thanks! |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 26, 2020
…onGH-21894) Currently, if `asyncio.wait_for()` itself is cancelled it will always raise `CancelledError` regardless if the underlying task is still running. This is similar to a race with the timeout, which is handled already. (cherry picked from commit a2118a1) Co-authored-by: Elvis Pranskevichus <elvis@magic.io>
Copy link
Copy Markdown
|
GH-21964 is a backport of this pull request to the 3.9 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-21965 is a backport of this pull request to the 3.8 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Sorry, @elprans and @1st1, I could not cleanly backport this to 3.7 due to a conflict. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 26, 2020
…onGH-21894) Currently, if `asyncio.wait_for()` itself is cancelled it will always raise `CancelledError` regardless if the underlying task is still running. This is similar to a race with the timeout, which is handled already. (cherry picked from commit a2118a1) Co-authored-by: Elvis Pranskevichus <elvis@magic.io>
ambv
pushed a commit
that referenced
this pull request
Aug 26, 2020
…1894) (GH-21964) Currently, if `asyncio.wait_for()` itself is cancelled it will always raise `CancelledError` regardless if the underlying task is still running. This is similar to a race with the timeout, which is handled already. (cherry picked from commit a2118a1) Co-authored-by: Elvis Pranskevichus <elvis@magic.io>
1st1
pushed a commit
that referenced
this pull request
Aug 26, 2020
…1894) (#21965) Currently, if `asyncio.wait_for()` itself is cancelled it will always raise `CancelledError` regardless if the underlying task is still running. This is similar to a race with the timeout, which is handled already. (cherry picked from commit a2118a1) Co-authored-by: Elvis Pranskevichus <elvis@magic.io>
elprans
added a commit
to elprans/cpython
that referenced
this pull request
Aug 26, 2020
…pythonGH-21894) Currently, if `asyncio.wait_for()` itself is cancelled it will always raise `CancelledError` regardless if the underlying task is still running. This is similar to a race with the timeout, which is handled already.. (cherry picked from commit a2118a1) Co-authored-by: Elvis Pranskevichus <elvis@magic.io>
Copy link
Copy Markdown
|
GH-21969 is a backport of this pull request to the 3.7 branch. |
Sorry, something went wrong.
elprans
added a commit
to MagicStack/asyncpg
that referenced
this pull request
Aug 27, 2020
`asyncio.wait_for()` currently has a bug where it raises a `CancelledError` even when the wrapped awaitable has completed. The upstream fix is in python/cpython#21894. This adds a workaround until the aforementioned PR is merged, backported and released. Co-authored-by: Adam Liddell <git@aliddell.com> Fixes: #467 Fixes: #547 Related: #468 Supersedes: #548
xzy3
pushed a commit
to xzy3/cpython
that referenced
this pull request
Oct 18, 2020
…on#21894) Currently, if `asyncio.wait_for()` itself is cancelled it will always raise `CancelledError` regardless if the underlying task is still running. This is similar to a race with the timeout, which is handled already.
ods
added a commit
to ods/cpython
that referenced
this pull request
May 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if asyncio.wait_for() itself is cancelled it will always
raise CancelledError regardless if the underlying task is still
running. This is similar to a race with the timeout, which is handled
already.
https://bugs.python.org/issue37658