Move generated package to src/ layout - #374
Merged
egpbos merged 2 commits intoMay 15, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
@Cmurilochem I was puzzled why you didn't have access, but for some reason you weren't part of the NLeSC/employees group (which has access to the repo). Now you are and you can do reviews (and everything else) :) |
Sorry, something went wrong.
Cmurilochem
reviewed
Apr 30, 2024
Cmurilochem
approved these changes
May 3, 2024
Cmurilochem
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
Great! Thanks for the clarification. Great job!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the generated package to the src/ based layout.
I think I've propagated this change everywhere necessary, and all tests currently pass.
Related issues: