FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update ruff configuration by sjvrijn · Pull Request #384 · NLeSC/python-template · GitHub

/ python-template Public

Update ruff configuration - #384

Merged
egpbos merged 3 commits into
mainfrom
378-ruff-config-update
Jul 30, 2024
ConversationCommits (3)ChecksFiles changed
Merged

Update ruff configuration#384
egpbos merged 3 commits into
mainfrom
378-ruff-config-update

Conversation

sjvrijn commented May 3, 2024

Copy link
Copy Markdown
Contributor

Description

Updated pre-commit script to use new explicit ruff check . syntax and ruff section in pyproject.toml to put most settings under tool.ruff.lint as instructed by deprecation warnings

Note

Note: based on #374, so marked as draft until that one is merged

Related issues

Instructions to review the pull request

$ cookiecutter -c 378-ruff-config-update https://github.com/NLeSC/python-template
# Fill with python-template-test info... or just press 'enter' 12 times
$ cd python-template-test
$ git init
$ git config --local core.hooksPath .githooks  # enable pre-commit git hook
$ git add .
$ git commit -m "initial commit"
Script .githooks/pre-commit triggered ...
Starting ruff analysis...
All checks passed!
Pre-commit checks completed successfully.
...
<regular commit summary output>

sjvrijn changed the title move generated package to src/ layout Update ruff configuration May 5, 2024

DaniBodor commented Jul 12, 2024

Copy link
Copy Markdown
Collaborator

So, I stupidly also started updating these before checking if anyone else had.
I made a few additional changes to what you did. I decided to rebase it onto this and create a PR pointing here.

Not sure whether it's better to merge that PR into here (if you agree with changes) and then merge everything into main at once, or whether we first finish this PR and then open a new one with the rest of the changes. What do you think @sjvrijn and @bouweandela?

DaniBodor mentioned this pull request Jul 12, 2024
Merged

bouweandela commented Jul 24, 2024

Copy link
Copy Markdown
Member

Let's first finish this one and merge it into main, if @sjvrijn has the time?

sjvrijn marked this pull request as ready for review July 29, 2024 08:24

sjvrijn commented Jul 29, 2024

Copy link
Copy Markdown
Contributor Author

@DaniBodor @bouweandela Thanks for picking this up. Does anything still need to be changed about this PR? Otherwise I'll just merge this and we can continue in #397

egpbos merged commit 3ce8ff9 into main Jul 30, 2024

egpbos commented Jul 30, 2024

Copy link
Copy Markdown
Collaborator

Done, thanks for this! I'm going to immediately copy this to DIANNA as well, where I had started a PR fixing the same issues 😅

egpbos deleted the 378-ruff-config-update branch July 30, 2024 10:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bouweandela bouweandela left review comments
DaniBodor DaniBodor left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ruff config update

4 participants

Back | FazBrowse Home | New Git URL