FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

514-make linting optional by fdiblen · Pull Request #568 · NLeSC/python-template · GitHub

514-make linting optional - #568

Merged
fdiblen merged 6 commits into
mainfrom
514_linting
Aug 27, 2024
Merged

514-make linting optional#568
fdiblen merged 6 commits into
mainfrom
514_linting

Conversation

fdiblen commented Aug 26, 2024
edited
Loading

Copy link
Copy Markdown
Member

Description

This PR makes linting integration optional.

Related issues:

Install the requirements

cd $(mktemp -d --tmpdir py-tmpl-XXXXXX)
pip install pipx
pipx install copier

Test 1:

Step-1:
Run the command below and say 'yes' to Add linting? question

copier copy --vcs-ref 514_linting https://github.com/nlesc/python-template test_yes

Step-2:
Run the command below and say 'no' to Add linting? question

copier copy --vcs-ref 514_linting https://github.com/nlesc/python-template test_no

What to check:

  • You should see the files below only when you say 'yes':
    • .github/workflows/next_steps_linting.yml
    • .github/workflows/next_steps_linting_issue.md
  • Check if there are mentions of linting or linter in any file of the generated package.

Test 2:

  • Push the generated package to a GitHub repository
  • Check if next_steps_linting.yml workflow runs
  • Check if next_steps_linting.yml workflow is removed after a successful run
  • Check if a GitHub issue about linting is created

fdiblen changed the title 514-add linting next step as a question 514-make linting optional Aug 26, 2024
fdiblen marked this pull request as ready for review August 27, 2024 10:04
fdiblen requested a review from lyashevska August 27, 2024 10:05
fdiblen mentioned this pull request Aug 27, 2024
3 tasks

sjvrijn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good to me 👍

lyashevska left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Works as expected!

fdiblen merged commit 44b8c5b into main Aug 27, 2024
fdiblen deleted the 514_linting branch August 27, 2024 11:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL