fix(image): apply tintColor correctly on iOS - #5546
Merged
manoldonev merged 1 commit intoMar 15, 2018
Merged
manoldonev merged 1 commit into
manoldonev merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
only reset image to non-template when tintColor is changed to a non-color (removed)
Copy link
Copy Markdown
Contributor
Author
|
👍 for PR |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@manoldonev Thanks for getting this merged ❤️ |
Sorry, something went wrong.
Copy link
Copy Markdown
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: Cherry-picked from #5266 due to CI infrastructure issues with the original PR.
Fixes #4778
Previously image was reset on every second call to setTintColor, which led to some weird behavior on iOS. Especially since setTintColor could be called many times, when set through property or style.
It now only resets image to non-template when tintColor is changed to a non-color value (e.g. removed).
NOTE: Fix for Android Image.tintColor here: NativeScript/tns-core-modules-widgets#110