This repository was archived by the owner on Mar 21, 2019. It is now read-only.
[Android] Fix missing use of ColorFilter in ImageView - #110
Merged
manoldonev merged 2 commits intoMar 20, 2018
Merged
manoldonev merged 2 commits into
manoldonev merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
|
Can one of the admins verify this patch? |
Sorry, something went wrong.
manoldonev
approved these changes
Mar 15, 2018
Copy link
Copy Markdown
Contributor
|
Merging this based on NativeScript/NativeScript#5555 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Android setting a tintColor on an <Image> had no effect.
Turns out Nativescript's custom ImageView never applied the ColorFilter to the Paint in the draw method. Likely due to refactoring of the draw method.
https://github.com/NativeScript/NativeScript/blob/02dba02e8bd35a270d6e2a8e4db0a18ec89c5615/tns-core-modules/ui/image/image.android.ts#L146