FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Bugfix: Image.tintColor not applied correctly on iOS by ddfreiling · Pull Request #5266 · NativeScript/NativeScript · GitHub

/ NativeScript Public

Bugfix: Image.tintColor not applied correctly on iOS - #5266

Closed
ddfreiling wants to merge 1 commit into
NativeScript:masterfrom
ddfreiling:fix/ios-image-tintcolor
ConversationCommits (1)ChecksFiles changed
Closed

Bugfix: Image.tintColor not applied correctly on iOS#5266
ddfreiling wants to merge 1 commit into
NativeScript:masterfrom
ddfreiling:fix/ios-image-tintcolor

Conversation

ddfreiling commented Jan 12, 2018

Copy link
Copy Markdown
Contributor

Fixes #4778

Previously image was reset on every second call to setTintColor, which led to some weird behavior on iOS. Especially since setTintColor could be called many times, when set through property or style.

It now only resets image to non-template when tintColor is changed to a non-color value (e.g. removed).

NOTE: Fix for Android Image.tintColor here: NativeScript/tns-core-modules-widgets#110

ns-bot commented Jan 12, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

22 similar comments

ns-bot commented Jan 12, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Jan 12, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Jan 12, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Jan 12, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Jan 12, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Jan 12, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Jan 12, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Jan 12, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Jan 12, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Jan 12, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Jan 12, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Jan 12, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Jan 12, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Jan 12, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Jan 12, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Jan 12, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Jan 12, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Jan 12, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Jan 12, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Jan 12, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Jan 12, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Jan 12, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ghost added the ♥ community label Jan 12, 2018

vakrilov commented Jan 25, 2018

Copy link
Copy Markdown
Contributor

Hey @ddfreiling - 10x for the pull request.
Can you rebase your branch on the current master.

fix(image): tintColor on iOS was not applied correctly
b280efe 
only reset image to non-template when tintColor is changed to a non-color (removed)
ddfreiling force-pushed the fix/ios-image-tintcolor branch from 1f0e8bf to b280efe Compare January 25, 2018 09:19

ddfreiling commented Jan 25, 2018

Copy link
Copy Markdown
Contributor Author

@vakrilov Rebased onto master, had to force push.

SvetoslavTsenov commented Jan 28, 2018

Copy link
Copy Markdown
Contributor

uitests

ns-bot commented Jan 28, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

SvetoslavTsenov commented Jan 28, 2018

Copy link
Copy Markdown
Contributor

cuteness

SvetoslavTsenov commented Jan 28, 2018

Copy link
Copy Markdown
Contributor

testsappng

ns-bot commented Feb 1, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ddfreiling commented Mar 5, 2018

Copy link
Copy Markdown
Contributor Author

Ping! Any feedback or estimate when this could be merged?

manoldonev commented Mar 15, 2018

Copy link
Copy Markdown
Contributor

test

manoldonev closed this Mar 15, 2018
ghost removed the ♥ community PR label Mar 15, 2018
manoldonev reopened this Mar 15, 2018
ghost assigned manoldonev Mar 15, 2018
ghost added the in progress label Mar 15, 2018

ns-bot commented Mar 15, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

2 similar comments

ns-bot commented Mar 15, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Mar 15, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

manoldonev mentioned this pull request Mar 15, 2018
Merged

manoldonev commented Mar 15, 2018

Copy link
Copy Markdown
Contributor

@ddfreiling I had to cherry-pick your fix and open a new PR (your authorship of the contribution is intact) as after some recent CI changes on our side we had some infrastructure issues with running our CI automated tests on the original PR.

Sorry for this!

manoldonev closed this Mar 15, 2018
ghost removed the in progress label Mar 15, 2018
ddfreiling deleted the fix/ios-image-tintcolor branch March 15, 2018 23:08

lock Bot commented Aug 26, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock Bot locked and limited conversation to collaborators Aug 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

manoldonev

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Using tint-color on images not working properly

5 participants

Back | FazBrowse Home | New Git URL