fix(android): default Label to vertical-align middle - #10233
Merged
NathanWalker merged 1 commit intoMar 13, 2023
Merged
NathanWalker merged 1 commit into
NathanWalker merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 24d3903. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 2 targets Sent with 💌 from NxCloud. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
All Android Label's defaulted to vertical-align top which never matched iOS. This has been broadly complained about and a PR was even submitted by an excellent contributor @Logikgate #8216 which properly addressed the issue but was closed years ago citing breaking changes.
What is the new behavior?
All Android Label's will default to vertical-align middle now to match iOS default. This is a long desired breaking change.
closes #3829
References:
#5977
#8216
https://github.com/orgs/NativeScript/discussions/10058
BREAKING CHANGES:
All Android Label's will default to vertical-align middle now to match iOS default. If you preferred the previous default top, you can just explicitly set it.