fix(android-label): Match iOS default vertical alignment - #8216
Closed
Logikgate wants to merge 1 commit into
Closed
Logikgate wants to merge 1 commit into
Logikgate wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Set gravity to CENTER_VERTICAL on android to match iOS labels which default to vertically centered Fixes issue NativeScript#3829
popcor255
approved these changes
Dec 30, 2019
Copy link
Copy Markdown
Contributor
|
Hey @Logikgate |
Sorry, something went wrong.
NathanWalker
added a commit
that referenced
this pull request
Mar 12, 2023
4 of 5 tasks
NathanWalker
added a commit
that referenced
this pull request
Mar 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set gravity to CENTER_VERTICAL on android to match iOS labels which default to vertically centered
Fixes issue #3829
PR Checklist
Playground
This playground displays the issue
What is the current behavior?
Labels on iOS are by default vertically aligned center in all layouts. On Android they are aligned top. Reference issue #3829.
What is the new behavior?
Labels on Android are now vertically aligned center by default
Fixes #3829.