iOS: setting borderRadius on Image with http/s source fails to render - #4832
Closed
justindujardin wants to merge 1 commit into
Closed
justindujardin wants to merge 1 commit into
justindujardin wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
|
Please sign CLA at http://www.nativescript.org/cla |
Sorry, something went wrong.
Copy link
Copy Markdown
|
CLA signature found, happy contributing! |
Sorry, something went wrong.
When loading an image from a remote resource, all the background properties are applied before the imageSource. When assigning borderRadius to an image, then later setting its imageSource would cause the image to be in a bad render state and completely disappear from the UI. I had to make the clone method public on Background. This patch clones the backgroundInternal property after async assignment of the imageSource.
justindujardin
force-pushed
the
image-border-radius-fail
branch
from
13711cd to
91f4538
Compare
September 12, 2017 16:06
PanayotCankov
approved these changes
Sep 25, 2017
Copy link
Copy Markdown
Contributor
|
@justindujardin I can't reproduce this issue with tns-core-modules@3.2 but I've saw another issue - borderRadius was not applied on Image element. This PR #4963 fix the new issue so I'm closing your PR in flavor of the other. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewer4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When loading an image from a remote resource, all the background properties are applied before the imageSource. When assigning borderRadius to an image, then later setting its imageSource would cause the image to be in a bad render state and completely disappear from the UI.
This patch clones the backgroundInternal property after async assignment of the imageSource, which causes the render state to be corrected.
Fixes #4804
I'm not sure this is the very best fix and am open to suggestions.