fix(android): nested fragment disappears on parent fragment removal - #6677
Merged
manoldonev merged 6 commits intoDec 12, 2018
Merged
manoldonev merged 6 commits into
manoldonev merged 6 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
manoldonev
force-pushed
the
mdonev/child-fragment-disappear-fix
branch
from
0757c3a to
8a677e7
Compare
December 6, 2018 15:37
…veScript/NativeScript into mdonev/child-fragment-disappear-fix
Copy link
Copy Markdown
Contributor
Author
|
test --ignore branch_tns_core_modules_widgets#mdonev/child-fragment-disappear-fix modal_navigation#mdonev/child-fragment-disappear-fix tests_app_transitions_android animations_android uitests_android ngapps_android api19 api23 api27 api28 |
Sorry, something went wrong.
MartoYankov
approved these changes
Dec 12, 2018
This was referenced Dec 12, 2018
Copy link
Copy Markdown
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: Known crash with Flip navigation due to not handling AnimatorSet animator properly.
TODO: consider implementing base fragment class in widgets and place the shared code between frame and tab fragment there.
TBD: consider do we need a property to enable / disable lollipop transitions (currently implicitly disabled for nested frame scenarios). This property could be useful in other cases as well e.g. this bug #6510 is only present for the "lollipop" Slide transition but if we use our own implementation, it is OK (if user could disable "lollipop" explicitly, it would work).
Fixes: #6641
Fixes: #6659
Fixes: #6698
Fixes: #6633
Fixes: #6630
Merge after NativeScript/tns-core-modules-widgets#154
BREAKING CHANGE:
[Android] Explode transition cannot be used when navigating in nested frame scenarios.
[Android] Custom nested fragments should inherit from org.nativescript.widgets.FragmentBase class instead of android.support.v4.app.Fragment directly to benefit from the applied workaround for https://code.google.com/p/android/issues/detail?id=55228