This repository was archived by the owner on Mar 21, 2019. It is now read-only.
refactor(android): extract FragmentBase class - #154
Merged
manoldonev merged 2 commits intoDec 12, 2018
Merged
manoldonev merged 2 commits into
manoldonev merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
SvetoslavTsenov
pushed a commit
that referenced
this pull request
Dec 19, 2018
SvetoslavTsenov
added a commit
that referenced
this pull request
Dec 19, 2018
* refactor(android): extract FragmentBase class (#154) * release: cut the 5.1.2 release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
Assignees
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract FragmentBase class to hold the common logic for applying a workaround for https://code.google.com/p/android/issues/detail?id=55228 (child fragments disappear when parent fragment is removed as all children are first removed from parent).
Must be merged before NativeScript/NativeScript#6677