feat(bundle): support for file qualifiers + builder refactor - #7386
Merged
manoldonev merged 14 commits intoJun 26, 2019
Merged
manoldonev merged 14 commits into
manoldonev merged 14 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
manoldonev
reviewed
Jun 21, 2019
Comment thread
apps/app/qualifiers-app/app-root.css
manoldonev
reviewed
Jun 21, 2019
vakrilov
force-pushed
the
builder-refactor
branch
from
96a83f3 to
5767b18
Compare
June 25, 2019 14:58
…pt into builder-refactor
manoldonev
approved these changes
Jun 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is in the PR
Both builder.ts and component-builder.ts refactored to work in webpack-only mode and to use only modules.
Implemented module-name-resolver that can resolve webpack (xml/js/css) that have file-qualifiers.
Fixes #7321
Fixes #7324
Related to NativeScript/nativescript-dev-webpack#902
Fixes #7392