fix(modal): throw from core properly caught and rejected - #1340
Merged
vakrilov merged 5 commits intoJun 27, 2018
Merged
vakrilov merged 5 commits into
vakrilov merged 5 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
This or NativeScript/NativeScript#5841 are viable fixes to this problem. |
Sorry, something went wrong.
NathanWalker
force-pushed
the
modal-throw-handling
branch
from
57633a7 to
a269f64
Compare
May 21, 2018 15:50
NathanWalker
force-pushed
the
modal-throw-handling
branch
2 times, most recently
from
98b094f to
3f0fdd3
Compare
May 24, 2018 00:47
NathanWalker
force-pushed
the
modal-throw-handling
branch
3 times, most recently
from
a520ccd to
8728f51
Compare
June 1, 2018 01:03
NathanWalker
force-pushed
the
modal-throw-handling
branch
from
8728f51 to
fde3067
Compare
June 18, 2018 15:05
vakrilov
approved these changes
Jun 25, 2018
Copy link
Copy Markdown
Contributor
|
test |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewerAssignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
App crashes if modal handling is invalid.
What is the new behavior?
Developers can now properly handle such a crash in the promise rejection of the ModalDialogService's showModal handling.