fix(modal): parent page invalid hierarchy handling - #5841
Closed
NathanWalker wants to merge 1 commit into
Closed
NathanWalker wants to merge 1 commit into
NathanWalker wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
NathanWalker
force-pushed
the
fix-modal-handling
branch
from
6c0a759 to
8ec7b0f
Compare
May 20, 2018 19:14
Merged
5 tasks
NathanWalker
force-pushed
the
fix-modal-handling
branch
4 times, most recently
from
7533051 to
276e57c
Compare
May 23, 2018 16:11
NathanWalker
commented
May 23, 2018
Comment thread
tns-core-modules/ui/core/view/view.ios.ts
Outdated
| // ensure view is protected against undefined access at each turn | ||
| if (view) { | ||
| view = view.parent as View; | ||
| if (view) { |
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Without this being guarding this while loop was very dangerous. Would often result in:
ERROR Error: Uncaught (in promise): TypeError: undefined is not an object (evaluating 'view.viewController') getParentWithViewController@file:///app/tns_modules/tns-core-modules/ui/core/view/view.js:251:30 _showNativeModalView@file:///app/tns_modules/tns-core-modules/ui/core/view/view.js:257:68 showModal@file:///app/tns_modules/tns-core-modules/ui/core/view/view-common.js:195:38
Sorry, something went wrong.
NathanWalker
force-pushed
the
fix-modal-handling
branch
from
276e57c to
5c43e49
Compare
May 27, 2018 05:13
NathanWalker
referenced
this pull request
May 30, 2018
#5881) * fix(ios-dialogs): unable to show dialog from modal view * tests(modal-navigation): add test that opens dialog inside modal view
NathanWalker
force-pushed
the
fix-modal-handling
branch
5 times, most recently
from
84b37b4 to
d553929
Compare
June 1, 2018 01:03
NathanWalker
force-pushed
the
fix-modal-handling
branch
from
d553929 to
f910448
Compare
June 18, 2018 15:11
Copy link
Copy Markdown
Contributor
|
Hey @NathanWalker - I've extended this PR in #5966 |
Sorry, something went wrong.
Copy link
Copy Markdown
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Apps break with the current throw without any effective way to handle. Additionally a while loop was being used without safe guards to prevent undefined access.
What is the new behavior?
With tracing on, developers can now properly debug their apps for various use cases without an untested (and most often not reproducible) ux flow/interaction hitting production resulting in this throw leaving the app unstable and unpredictable. Also proper safe guards have been added to prevent undefined access.