FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Renamed wrongly named file by kilasuit · Pull Request #10659 · PowerShell/PowerShell · GitHub

Renamed wrongly named file - #10659

Merged
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
kilasuit:invokeExpressionCmdlet
Oct 7, 2019
Merged

Renamed wrongly named file#10659
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
kilasuit:invokeExpressionCmdlet

Conversation

Ryan Yates (kilasuit) commented Oct 1, 2019
edited by daxian-dbw
Loading

Copy link
Copy Markdown
Collaborator

PR Summary

This PR fixes the incorrectly named InvokeCommandCmdlet.cs which contained Invoke-Expression definition.

PR Context

fix #9807
Make sure file name matches intended content

PR Checklist

Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Oct 1, 2019
Ilya (iSazonov) added this to the 7.0.0-preview.5 milestone Oct 1, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We are not very consistent in our file naming, but I believe the file name should be 'InvokeExpressionCommand.cs'.

Aditya Patwardhan (@adityapatwardhan) Will renaming a source file cause any build/packaging problems?

Copy link
Copy Markdown
Member

I agree with Paul Higinbotham (@PaulHigin)

Copy link
Copy Markdown
Collaborator Author

Paul Higinbotham (@PaulHigin) - I've locally tested that change will still build pwsh & the command runs fine & also renamed the file to InvokeExpressionCommand.cs based on your comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Copy link
Copy Markdown
Member

PoshChan-Bot (@PoshChan) please retry macos

Copy link
Copy Markdown
Collaborator

Steve Lee (@SteveL-MSFT), successfully started retry of PowerShell-CI-macOS

Copy link
Copy Markdown
Member

Paul Higinbotham (@PaulHigin) renaming this file shouldn't cause any issues as build csproj implicitly includes cs files rather than explicitly. packaging only cares about the binary output and not source files.

Dongbo Wang (daxian-dbw) changed the title renamed wrongly named file - fixes #9807 Renamed wrongly named file Oct 7, 2019
Dongbo Wang (daxian-dbw) merged commit c08c7e4 into PowerShell:master Oct 7, 2019
Ryan Yates (kilasuit) deleted the invokeExpressionCmdlet branch October 7, 2019 20:50

Copy link
Copy Markdown

🎉v7.0.0-preview.5 has been released which incorporates this pull request.:tada:

Handy links:

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

InvokeCommandCmdlet.cs is actually for invoke-expression cmdlet

6 participants


Back | FazBrowse Home | New Git URL