| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
There was a problem hiding this comment.
We are not very consistent in our file naming, but I believe the file name should be 'InvokeExpressionCommand.cs'.
Aditya Patwardhan (@adityapatwardhan) Will renaming a source file cause any build/packaging problems?
Sorry, something went wrong.
|
I agree with Paul Higinbotham (@PaulHigin) |
Sorry, something went wrong.
|
Paul Higinbotham (@PaulHigin) - I've locally tested that change will still build pwsh & the command runs fine & also renamed the file to InvokeExpressionCommand.cs based on your comment |
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
|
PoshChan-Bot (@PoshChan) please retry macos |
Sorry, something went wrong.
|
Steve Lee (@SteveL-MSFT), successfully started retry of PowerShell-CI-macOS |
Sorry, something went wrong.
|
Paul Higinbotham (@PaulHigin) renaming this file shouldn't cause any issues as build csproj implicitly includes cs files rather than explicitly. packaging only cares about the binary output and not source files. |
Sorry, something went wrong.
|
🎉v7.0.0-preview.5 has been released which incorporates this pull request.:tada: Handy links: |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
PR Summary
This PR fixes the incorrectly named InvokeCommandCmdlet.cs which contained Invoke-Expression definition.
PR Context
fix #9807
Make sure file name matches intended content
PR Checklist