| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
This PR has 0 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience! Quantification details
Label : No Changes Size : +0 -0 Percentile : 0% Total files changed: 0 Change summary by file extension: Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Sorry, something went wrong.
|
We lost git history if we renamed the file. |
Sorry, something went wrong.
Ilya (@iSazonov) Understandable. I've seen PRs in the past like #10659 which have renamed these files to more suitable names. Is this something we don't do anymore because of git history loss? Happy to close PR if this is the case. |
Sorry, something went wrong.
|
Test-Path is not stable (in contrast with Invoke-Expression) so I think the history is important. |
Sorry, something went wrong.
There was a problem hiding this comment.
Test-Path has been around since the beginning, so it's pretty stable now. I looked at the change history, and most of them are parts of big logistic changes, such as code cleanup on using directive and etc. So, I think it's okay to take this change.
Sorry, something went wrong.
|
🎉v7.4.0-preview.4 has been released which incorporates this pull request.:tada: Handy links: |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
PR Summary
Renaming file from PingPathCommand.cs to TestPathCommand.cs to match cmdlet name better.
PR Context
PR Checklist
(which runs in a different PS Host).