Port GetProcessorArchitecture() by iSazonov · Pull Request #11046 · PowerShell/PowerShell · GitHub

PR Summary

Before the change GetProcessorArchitecture() call Windows P/Invoke so on Unix it would throw if user loaded a module with ProcessorArchitecture value in the module manifest. Now we use ProcessorArchitecture from current assembly.

PR Context

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
Breaking changes
- None
- OR
- Experimental feature(s) needed
  - Experimental feature name(s):
User-facing changes
- Not Applicable
- OR
- Documentation needed
  - Issue filed:
Testing - New and feature
- N/A or can only be tested interactively
- OR
- Make sure you've added a new test if existing tests do not effectively test the code changed
Tooling
- I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- OR
- I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
  - Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
  - Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
  - Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
  - Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

Steve Lee (@SteveL-MSFT) Do you agree to merge the PR before GA?

Aditya Patwardhan (@adityapatwardhan) Please review the PR again.

After looking in depth how the method is used I very wonder that we implement the conversion of these two enums if we can request current value from an assembly using Reflection.
On my system typeof(object).Assembly.GetName().ProcessorArchitecture returns Amd64.

Ilya (@iSazonov) , can you please double check that currently GetProcessorArchitecture() returns system-wide info and comment on this function is wrong?
If that's the case, then probably to avoid future confusion:

current GetProcessorArchitecture() should be renamed across the code to something like GetSystemProcessorArchitecture(), and comment updated;
since the functionality of getting current process arch is also needed, code of this PR should go into PsUtils as a separate method like GetCurrentProcessProcessorArchitecture().

Andrew (@anmenaga) If the name confuses you we could remove the method at all because it is used in one place/scenario. Th scenario is a module loading. We read ProcessorArchitecture parameter from the module manifest and check that we can load the module. The check is to compare the ProcessorArchitecture parameter and ProcessorArchitecture property from current assembly. And we can do this directly. I pulled the commit.

Andrew (@anmenaga) Please update your review.

Andrew (@anmenaga) Could you please continue?

Steve Lee (@SteveL-MSFT) Andrew (@anmenaga) I think the PR could be in 7.0.

Steve Lee (@SteveL-MSFT) Sorry, I did not saw the issue. New tests are added.

Steve Lee (@SteveL-MSFT) It seems I need help to fix tests on Unix-s. :-( I guess SMA compiled to MSIL on Unix-s. In the case I don't know how make functional tests on Unix-s.

Should have in finally to ensure this cleans up if test fails for some reason

Done.

Extra whitespace

Done.

Ilya (@iSazonov) You can probably not even worry about Add-Type, the module manifest issue was at validation time when it is imported so you can just generate the module manifest with ProcessorArchitecture and it should succeed on compatible arch and fail on not-compatible arch

Steve Lee (@SteveL-MSFT) I try to create functional tests to ensure that scenario like #6533 really works. But test failures show that perhaps the PR doesn't fix #6533 in general (the PR only removes broken p/invoke but do not ensure that import-module works) because Roslyn works in another way on Unix-s and probably loader too. Now I set to skip new tests on Unix-s.

Notice. The code was not covered by tests. Now only Windows on Intel is covered. Unix-s and Arm are not covered.

🎉v7.0.0-rc.2 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

Port GetProcessorArchitecture()

3dbf878

Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 12, 2019

Ilya (iSazonov) added this to the 7.0.0-preview.6 milestone Nov 12, 2019

Ilya (iSazonov) requested review from Steve Lee (SteveL-MSFT) and Dongbo Wang (daxian-dbw) November 12, 2019 14:58

PoshChan-Bot (PoshChan) reviewed Nov 12, 2019

View reviewed changes

Comment thread src/System.Management.Automation/engine/Modules/ModuleCmdletBase.cs

Aditya Patwardhan (adityapatwardhan) approved these changes Nov 12, 2019

View reviewed changes

Ilya (iSazonov) self-assigned this Nov 14, 2019

Use replection to get current ProcessorArchitecture

726f82c

Ilya (iSazonov) mentioned this pull request Nov 15, 2019

Importing Windows PowerShell modules in PowerShell Core #10973

Merged

14 tasks

Deleted user (ghost) reviewed Nov 15, 2019

View reviewed changes

Comment thread src/System.Management.Automation/engine/Modules/ModuleCmdletBase.cs Outdated

Remov comment

c816479

PoshChan-Bot (PoshChan) reviewed Nov 15, 2019

View reviewed changes

Comment thread src/System.Management.Automation/engine/Modules/ModuleCmdletBase.cs

Dongbo Wang (daxian-dbw) requested a review from Andrew (anmenaga) November 15, 2019 20:18

Remove old method

30d9a45

PoshChan-Bot (PoshChan) reviewed Nov 16, 2019

View reviewed changes

Comment thread src/System.Management.Automation/engine/Modules/ModuleCmdletBase.cs

Travis Plunk (TravisEz13) modified the milestones: 7.0.0-preview.6, 7.0.0-rc.1, 7.1.0-preview.1 Nov 22, 2019

Steve Lee (SteveL-MSFT) modified the milestones: 7.1.0-preview.1, GA-consider Jan 9, 2020

Steve Lee (SteveL-MSFT) mentioned this pull request Jan 9, 2020

Module manifest .psd1 file on linux/mac doesn't support ProcessorArchitecture='AMD64' or 'x86' #6533

Closed

Add tests

0eca1f0

PoshChan-Bot (PoshChan) reviewed Jan 10, 2020

View reviewed changes

Comment thread src/System.Management.Automation/engine/Modules/ModuleCmdletBase.cs

PoshChan-Bot (PoshChan) reviewed Jan 10, 2020

View reviewed changes

Comment thread src/System.Management.Automation/engine/Modules/ModuleCmdletBase.cs

Skip on Unix X86 on X64 tests

1621a47

PoshChan-Bot (PoshChan) reviewed Jan 10, 2020

View reviewed changes

Comment thread src/System.Management.Automation/engine/Modules/ModuleCmdletBase.cs

PoshChan-Bot (PoshChan) reviewed Jan 10, 2020

View reviewed changes

Comment thread src/System.Management.Automation/engine/Modules/ModuleCmdletBase.cs

Steve Lee (SteveL-MSFT) requested changes Jan 10, 2020

View reviewed changes

ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jan 10, 2020

Dongbo Wang (daxian-dbw) reviewed Jan 10, 2020

View reviewed changes

Comment thread src/System.Management.Automation/utils/PsUtils.cs

ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jan 11, 2020

Ilya (iSazonov) added 2 commits January 11, 2020 12:34

Address feed back and skip test on Unix-s

8dfb4ba

Cleanup code

4d7965a

Steve Lee (SteveL-MSFT) approved these changes Jan 13, 2020

View reviewed changes

Ilya (iSazonov) merged commit 0dfeeb5 into PowerShell:master Jan 14, 2020

Ilya (iSazonov) deleted the port-getprocessorarchitecture branch January 14, 2020 03:41

Aditya Patwardhan (adityapatwardhan) modified the milestones: GA-consider, GA-approved Jan 14, 2020

Dongbo Wang (daxian-dbw) pushed a commit that referenced this pull request Jan 14, 2020

Port GetProcessorArchitecture() (#11046 )

67fb8f1

Dongbo Wang (daxian-dbw) modified the milestones: GA-approved, 7.0.0-rc.2 Jan 14, 2020

ghost mentioned this pull request Jan 16, 2020

GetProcessorArchitecture in PSUtil.cs is not ported #4474

Closed

Ilya (iSazonov) mentioned this pull request Oct 8, 2021

Add processor architecture information in $PSVersionTable #16209

Closed

Travis Plunk (TravisEz13) mentioned this pull request Oct 12, 2022

Back-port to 7.0: Update list of PowerShell team members in release tools #18266

Merged

22 tasks

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026

Port GetProcessorArchitecture() (PowerShell#11046 )

db28f88

+                      Get-TP -ErrorAction SilentlyContinue | Should -BeExactly "$arch"
+                      Remove-Module "TP_$arch"
+                      Remove-Item -LiteralPath $testFolder -Recurse -Force -ErrorAction SilentlyContinue > $null

+                      Add-Type -TypeDefinition $a -CompilerOptions "/platform:$roslynArch" -OutputAssembly $assemblyPath
+                      New-ModuleManifest -Path $modulePath -NestedModules "TP_$arch.dll" -RequiredAssemblies "TP_$arch.dll" -ProcessorArchitecture $arch -CmdletsToExport "Get-TP"
+                      Import-Module $modulePath

Port GetProcessorArchitecture() by iSazonov · Pull Request #11046 · PowerShell/PowerShell · GitHub

Uh oh!

Port GetProcessorArchitecture() - #11046

Port GetProcessorArchitecture()#11046Ilya (iSazonov) merged 8 commits intoPowerShell:masterPowerShell/PowerShell:masterfrom iSazonov:port-getprocessorarchitectureiSazonov/PowerShell:port-getprocessorarchitectureCopy head branch name to clipboard

Conversation

Ilya (iSazonov) commented Nov 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Context

PR Checklist

Uh oh!

Uh oh!

Ilya (iSazonov) commented Nov 14, 2019

Uh oh!

Ilya (iSazonov) commented Nov 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Andrew (anmenaga) commented Nov 15, 2019

Uh oh!

Ilya (iSazonov) commented Nov 16, 2019

Uh oh!

Uh oh!

Ilya (iSazonov) commented Nov 19, 2019

Uh oh!

Ilya (iSazonov) commented Dec 10, 2019

Uh oh!

Ilya (iSazonov) commented Dec 18, 2019

Uh oh!

Ilya (iSazonov) commented Jan 10, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Ilya (iSazonov) commented Jan 10, 2020

Uh oh!

Steve Lee (SteveL-MSFT) Jan 10, 2020

Choose a reason for hiding this comment

Uh oh!

Ilya (iSazonov) Jan 11, 2020

Choose a reason for hiding this comment

Uh oh!

Steve Lee (SteveL-MSFT) Jan 10, 2020

Choose a reason for hiding this comment

Uh oh!

Ilya (iSazonov) Jan 11, 2020

Choose a reason for hiding this comment

Uh oh!

Steve Lee (SteveL-MSFT) commented Jan 10, 2020

Uh oh!

Uh oh!

Ilya (iSazonov) commented Jan 11, 2020

Uh oh!

Ilya (iSazonov) commented Jan 14, 2020

Uh oh!

Deleted user (ghost) commented Jan 16, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Port GetProcessorArchitecture()#11046
Ilya (iSazonov) merged 8 commits into
PowerShell:masterfrom
iSazonov:port-getprocessorarchitecture

Ilya (iSazonov) commented Nov 12, 2019 •
edited
Loading

Ilya (iSazonov) commented Nov 15, 2019 •
edited
Loading