FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix test failing when UnixStat feature is disabled by adityapatwardhan · Pull Request #11370 · PowerShell/PowerShell · GitHub

Fix test failing when UnixStat feature is disabled - #11370

Merged
Aditya Patwardhan (adityapatwardhan) merged 1 commit into
PowerShell:masterfrom
adityapatwardhan:FixUnixStatTests
Dec 20, 2019
Merged

Fix test failing when UnixStat feature is disabled#11370
Aditya Patwardhan (adityapatwardhan) merged 1 commit into
PowerShell:masterfrom
adityapatwardhan:FixUnixStatTests

Conversation

Aditya Patwardhan (adityapatwardhan) commented Dec 17, 2019
edited
Loading

Copy link
Copy Markdown
Member

PR Summary

Fixes #11357

PR Context

We check if the experimental feature is enabled before determining the expected value.

PR Checklist

Copy link
Copy Markdown
Member

close/open PR to re-trigger CIs.

Copy link
Copy Markdown
Member Author

PoshChan-Bot (@PoshChan) please rebuild all

Copy link
Copy Markdown
Collaborator

Aditya Patwardhan (@adityapatwardhan), successfully started rebuild of PowerShell-CI-static-analysis, PowerShell-CI-Windows, PowerShell-CI-macOS, PowerShell-CI-Linux

@@ -15,7 +15,9 @@ Describe "Get-FormatData" -Tags "CI" {
$format.TypeNames | Should -HaveCount 2

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Aditya Patwardhan (@adityapatwardhan), your last commit had 1 failures in PowerShell-CI-macos
Validate Update-Help from the Web for all PowerShell modules for user scope..Validate Update-Help for module 'PackageManagement' with scope as 'False'

Expected 1, but got 0.
at <ScriptBlock>, /Users/runner/runners/2.160.1/work/1/s/test/powershell/engine/Help/UpdatableHelpSystem.Tests.ps1: line 181
181:     $helpFilesInstalled.Count | Should -Be $expectedHelpFiles.Count

Copy link
Copy Markdown
Member Author

PoshChan-Bot (@PoshChan) please retry macos

Copy link
Copy Markdown
Collaborator

Aditya Patwardhan (@adityapatwardhan), successfully started retry of PowerShell-CI-macOS

Copy link
Copy Markdown
Member Author

PoshChan-Bot (@PoshChan) please rebuild all

Copy link
Copy Markdown
Collaborator

Aditya Patwardhan (@adityapatwardhan), successfully started rebuild of PowerShell-CI-static-analysis, PowerShell-CI-Windows, PowerShell-CI-macOS, PowerShell-CI-Linux

Copy link
Copy Markdown

🎉v7.0.0-rc.2 has been released which incorporates this pull request.:tada:

Handy links:

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests failing due to UnixStat feature being disabled

3 participants


Back | FazBrowse Home | New Git URL