Revert the PRs that made `DBNull.Value` and `NullString.Value` treated as `$null` by daxian-dbw · Pull Request #11584 · PowerShell/PowerShell · GitHub

PR Summary

Revert the PRs that made DBNull.Value and NullString.Value treated as $null:

Also update code for Coalescing and Null-conditional operators to use 'IsNull' instead.

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
Breaking changes
- None
- OR
- Experimental feature(s) needed
  - Experimental feature name(s):
User-facing changes
- Not Applicable
- OR
- Documentation needed
  - Issue filed:
Testing - New and feature
- N/A or can only be tested interactively
- OR
- Make sure you've added a new test if existing tests do not effectively test the code changed
Tooling
- I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- OR
- I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
  - Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
  - Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
  - Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
  - Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

…ullLike() (PowerShell#10781)" This reverts commit 25286eb.

…null` when comparing with `$null` and casting to bool (PowerShell#9794)" This reverts commit b34e331.

Approved with nitpicks

Aditya Patwardhan (@adityapatwardhan) You just need to review the 3rd commit. The previous 2 are from git revert those 2 PRs.

Aditya Patwardhan (@adityapatwardhan) Travis Plunk (@TravisEz13) Also, the windows build failed at the packaging phase with a "calling method on null-value" error:

You cannot call a method on a null-valued expression.
at Invoke-CIFinish, D:\a\1\s\tools\ci.psm1: line 452
at <ScriptBlock>, D:\a\_temp\00413339-7785-4f63-ab8a-bab4a33c6cbe.ps1: line 4
at <ScriptBlock>, <No file>: line 1
You cannot call a method on a null-valued expression.
At D:\a\1\s\tools\ci.psm1:452 char:9
+         $previewLabel = $previewVersion[1].replace('.','')
+         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (:) [], RuntimeException
    + FullyQualifiedErrorId : InvokeMethodOnNull

See https://dev.azure.com/powershell/PowerShell/_build/results?buildId=43557&view=logs&j=1057fe42-c88b-5deb-88ad-59245c714665&t=1888043b-254d-5761-80ec-47d0d8adc59a

Steve Lee (@SteveL-MSFT) The PR is targetting RC.2 branch so it is auto approved for RC.

Merged this even though there were failures in Windows packaging as we have differences in content in metadata.json in RC.2 branch. It was fixed to unblock CI with PR #11372
We do not need to take this change to the RC.2 branch.

🎉v7.0.0-rc.2 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

Why was this reverted?
Is this final or are you planing to change it again in the future?
BTW probably should have been listed under the "Breaking Changes" category in the v7.0.0-rc.2 Release note.

ili101 the change was never included in a stable release, so reverting it is not a breaking change. Please see this issue for discussion -- depending on what is decided by the PS team and community, the change may be reintroduced, likely with some alterations if it is, in a later release, likely at least 7.1 🙂

…d as `$null` (PowerShell#11584)

Dongbo Wang (daxian-dbw) added 3 commits January 14, 2020 12:59

Revert "Use more effective evaluation order in LanguagePrimitives.IsN…

e035a28

…ullLike() (PowerShell#10781)" This reverts commit 25286eb.

Revert "Consider DBNull.Value and NullString.Value the same as `$…

21a8a3f

…null` when comparing with `$null` and casting to bool (PowerShell#9794)" This reverts commit b34e331.

Update Coalescing and Null-conditional operators to use 'IsNull' instead

ce64abb

ghost assigned Aditya Patwardhan (adityapatwardhan) Jan 14, 2020

Dongbo Wang (daxian-dbw) requested review from Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan) and Andrew (anmenaga) January 14, 2020 21:21

PoshChan-Bot (PoshChan) reviewed Jan 14, 2020

View reviewed changes

Comment thread src/System.Management.Automation/engine/LanguagePrimitives.cs

Aditya Patwardhan (adityapatwardhan) approved these changes Jan 14, 2020

View reviewed changes

PoshChan-Bot (PoshChan) reviewed Jan 14, 2020

View reviewed changes

Comment thread src/System.Management.Automation/engine/LanguagePrimitives.cs

PoshChan-Bot (PoshChan) reviewed Jan 14, 2020

View reviewed changes

Comment thread src/System.Management.Automation/engine/LanguagePrimitives.cs

Dongbo Wang (daxian-dbw) added 2 commits January 14, 2020 16:07

Fix 2 test failures

9923f3b

Fix the spelling issue in 'preview.md'

8c8cb32

Steve Lee (SteveL-MSFT) added this to the GA-consider milestone Jan 15, 2020

Aditya Patwardhan (adityapatwardhan) merged commit d99b325 into PowerShell:release/v7.0.0-rc.2 Jan 15, 2020

Dongbo Wang (daxian-dbw) deleted the revert branch January 15, 2020 00:47

Aditya Patwardhan (adityapatwardhan) modified the milestones: GA-consider, 7.0.0-rc.2 Jan 15, 2020

Dongbo Wang (daxian-dbw) added a commit to daxian-dbw/PowerShell that referenced this pull request Jan 21, 2020

Revert the PRs that made DBNull.Value and NullString.Value treate…

b90e530

…d as `$null` (PowerShell#11584)

Dongbo Wang (daxian-dbw) mentioned this pull request Jan 21, 2020

Revert the PRs that made DBNull.Value and NullString.Value treated as $null #11648

Merged

14 tasks

Travis Plunk (TravisEz13) mentioned this pull request Oct 12, 2022

Back-port to 7.0: Update list of PowerShell team members in release tools #18266

Merged

22 tasks

Revert the PRs that made `DBNull.Value` and `NullString.Value` treated as `$null` by daxian-dbw · Pull Request #11584 · PowerShell/PowerShell · GitHub

Uh oh!

Revert the PRs that made DBNull.Value and NullString.Value treated as $null - #11584

Revert the PRs that made DBNull.Value and NullString.Value treated as $null#11584
Aditya Patwardhan (adityapatwardhan) merged 5 commits into
PowerShell:release/v7.0.0-rc.2from
daxian-dbw:revert

Dongbo Wang (daxian-dbw) commented Jan 14, 2020 •
edited
Loading

Uh oh!

Uh oh!

Uh oh!

Aditya Patwardhan (adityapatwardhan) left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Dongbo Wang (daxian-dbw) commented Jan 14, 2020

Uh oh!

Uh oh!

Uh oh!

Dongbo Wang (daxian-dbw) commented Jan 14, 2020

Uh oh!

Aditya Patwardhan (adityapatwardhan) commented Jan 15, 2020

Uh oh!

Deleted user (ghost) commented Jan 16, 2020

Uh oh!

ili101 commented Jan 17, 2020

Uh oh!

Rain Sallow (/u/ta11ow) (vexx32) commented Jan 17, 2020 •
edited
Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Revert the PRs that made `DBNull.Value` and `NullString.Value` treated as `$null` by daxian-dbw · Pull Request #11584 · PowerShell/PowerShell · GitHub

Uh oh!

Revert the PRs that made DBNull.Value and NullString.Value treated as $null - #11584

Revert the PRs that made DBNull.Value and NullString.Value treated as $null#11584Aditya Patwardhan (adityapatwardhan) merged 5 commits intoPowerShell:release/v7.0.0-rc.2PowerShell/PowerShell:release/v7.0.0-rc.2from daxian-dbw:revertdaxian-dbw/PowerShell:revertCopy head branch name to clipboard

Conversation

Dongbo Wang (daxian-dbw) commented Jan 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Checklist

Uh oh!

Uh oh!

Aditya Patwardhan (adityapatwardhan) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Dongbo Wang (daxian-dbw) commented Jan 14, 2020

Uh oh!

Uh oh!

Uh oh!

Dongbo Wang (daxian-dbw) commented Jan 14, 2020

Uh oh!

Aditya Patwardhan (adityapatwardhan) commented Jan 15, 2020

Uh oh!

Deleted user (ghost) commented Jan 16, 2020

Uh oh!

ili101 commented Jan 17, 2020

Uh oh!

Rain Sallow (/u/ta11ow) (vexx32) commented Jan 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Revert the PRs that made DBNull.Value and NullString.Value treated as $null#11584
Aditya Patwardhan (adityapatwardhan) merged 5 commits into
PowerShell:release/v7.0.0-rc.2from
daxian-dbw:revert

Dongbo Wang (daxian-dbw) commented Jan 14, 2020 •
edited
Loading

Rain Sallow (/u/ta11ow) (vexx32) commented Jan 17, 2020 •
edited
Loading