Revert the PRs that made `DBNull.Value` and `NullString.Value` treated as `$null` by daxian-dbw · Pull Request #11648 · PowerShell/PowerShell · GitHub

PR Summary

Revert the PRs that made DBNull.Value and NullString.Value treated as $null:

Also update code for Coalescing and Null-conditional operators to use 'IsNull' instead.
This is cherry-picked from the v7.0.0-rc.2 tagged branch. The reversion was did originally in #11584 targeting the v7.0.0-rc.2 release branch.

Note: there are nice syntax/formatting changes made in the original PRs that I wish we could keep, but making extra changes to keep those in this PR will complicate the reversion and may result in mistakes. So I just revert all changes from those 2 PRs.

PR Context

There has been concerns about the inconsistencies the original changes brought to the language.
See #11604 for the discussion going on.

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
Breaking changes
- None
- OR
- Experimental feature(s) needed
  - Experimental feature name(s):
User-facing changes
- Not Applicable
- OR
- Documentation needed
  - Issue filed:
Testing - New and feature
- N/A or can only be tested interactively
- OR
- Make sure you've added a new test if existing tests do not effectively test the code changed
Tooling
- I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- OR
- I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
  - Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
  - Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
  - Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
  - Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

…d as `$null` (PowerShell#11584)

…re turned on by default

Revert the changes in Startup.Tests.ps1 because the experimental features are turned on by default in the master branch, which causes those 2 assemblies get loaded at startup.

Dongbo Wang (@daxian-dbw), your last commit had 1 failures in PowerShell-CI-static-analysis
Verify Markdown Links.Verify links in /home/vsts/work/1/s/CHANGELOG/6.0.md.https://msdn.microsoft.com/powershell/reference/6/about/about_jobs should work

Failed to complete request to "https://msdn.microsoft.com/powershell/reference/6/about/about_jobs". Response status code does not indicate success: 404 (Not Found).
at <ScriptBlock>, /home/vsts/work/1/s/test/common/markdown/markdown-link.tests.ps1: line 119
119:                                     throw "Failed to complete request to `"$url`". $($_.Exception.Message)"

This will be addressed by #11653

Aditya Patwardhan (@adityapatwardhan) Can you please merge this PR? Thanks!

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

…d as `$null` (PowerShell#11648)

Revert the PRs that made DBNull.Value and NullString.Value treate…

b90e530

…d as `$null` (PowerShell#11584)

Dongbo Wang (daxian-dbw) requested review from Aditya Patwardhan (adityapatwardhan) and Rain Sallow (/u/ta11ow) (vexx32) January 21, 2020 19:30

ghost assigned Dongbo Wang (daxian-dbw) Jan 21, 2020

Dongbo Wang (daxian-dbw) assigned Aditya Patwardhan (adityapatwardhan) and unassigned Dongbo Wang (daxian-dbw) Jan 21, 2020

Dongbo Wang (daxian-dbw) added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Jan 21, 2020

Dongbo Wang (daxian-dbw) added this to the 7.1.0-preview.1 milestone Jan 21, 2020

Rain Sallow (/u/ta11ow) (vexx32) approved these changes Jan 21, 2020

View reviewed changes

PoshChan-Bot (PoshChan) reviewed Jan 21, 2020

View reviewed changes

Comment thread src/System.Management.Automation/engine/LanguagePrimitives.cs

PoshChan-Bot (PoshChan) reviewed Jan 21, 2020

View reviewed changes

Comment thread src/System.Management.Automation/engine/LanguagePrimitives.cs

Revert the changes in Startup.Tests.ps1 since experimental features a…

965bbcc

…re turned on by default

PoshChan-Bot (PoshChan) reviewed Jan 22, 2020

View reviewed changes

Ilya (iSazonov) reviewed Jan 22, 2020

View reviewed changes

Comment thread src/System.Management.Automation/engine/LanguagePrimitives.cs Outdated

Address Ilya's comment

b94e02f

Ilya (iSazonov) approved these changes Jan 22, 2020

View reviewed changes

Aditya Patwardhan (adityapatwardhan) approved these changes Jan 29, 2020

View reviewed changes

Aditya Patwardhan (adityapatwardhan) merged commit a4c32bc into PowerShell:master Jan 29, 2020

Dongbo Wang (daxian-dbw) deleted the revert branch January 29, 2020 22:13

Ilya (iSazonov) mentioned this pull request Feb 1, 2020

DBNull: Some Fields With False Are Now Seen As Equal To DBNull - Changed After Preview 1 #10980

Closed

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026

Revert the PRs that made DBNull.Value and NullString.Value treate…

6b9da41

…d as `$null` (PowerShell#11648)

Revert the PRs that made `DBNull.Value` and `NullString.Value` treated as `$null` by daxian-dbw · Pull Request #11648 · PowerShell/PowerShell · GitHub

Uh oh!

Revert the PRs that made DBNull.Value and NullString.Value treated as $null - #11648

Revert the PRs that made DBNull.Value and NullString.Value treated as $null#11648
Aditya Patwardhan (adityapatwardhan) merged 3 commits into
PowerShell:masterfrom
daxian-dbw:revert

Dongbo Wang (daxian-dbw) commented Jan 21, 2020 •
edited
Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Dongbo Wang (daxian-dbw) commented Jan 22, 2020

Uh oh!

PoshChan-Bot (PoshChan) Jan 22, 2020

Uh oh!

Dongbo Wang (daxian-dbw) Jan 22, 2020

Uh oh!

Uh oh!

Dongbo Wang (daxian-dbw) commented Jan 28, 2020

Uh oh!

Deleted user (ghost) commented Mar 26, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		@@ -593,7 +593,9 @@ public static PSDataCollection<PSObject> GetPSDataCollection(object inputValue)
		/// <param name="second">Object to compare first to.</param>

Revert the PRs that made `DBNull.Value` and `NullString.Value` treated as `$null` by daxian-dbw · Pull Request #11648 · PowerShell/PowerShell · GitHub

Uh oh!

Revert the PRs that made DBNull.Value and NullString.Value treated as $null - #11648

Revert the PRs that made DBNull.Value and NullString.Value treated as $null#11648Aditya Patwardhan (adityapatwardhan) merged 3 commits intoPowerShell:masterPowerShell/PowerShell:masterfrom daxian-dbw:revertdaxian-dbw/PowerShell:revertCopy head branch name to clipboard

Conversation

Dongbo Wang (daxian-dbw) commented Jan 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Context

PR Checklist

Uh oh!

Uh oh!

Uh oh!

Dongbo Wang (daxian-dbw) commented Jan 22, 2020

Uh oh!

PoshChan-Bot (PoshChan) Jan 22, 2020

Choose a reason for hiding this comment

Uh oh!

Dongbo Wang (daxian-dbw) Jan 22, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Dongbo Wang (daxian-dbw) commented Jan 28, 2020

Uh oh!

Deleted user (ghost) commented Mar 26, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Revert the PRs that made DBNull.Value and NullString.Value treated as $null#11648
Aditya Patwardhan (adityapatwardhan) merged 3 commits into
PowerShell:masterfrom
daxian-dbw:revert

Dongbo Wang (daxian-dbw) commented Jan 21, 2020 •
edited
Loading