FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Set `StrictMode` version `3.0` by xtqqczze · Pull Request #11563 · PowerShell/PowerShell · GitHub

/ PowerShell Public

Set StrictMode version 3.0 - #11563

Merged
Travis Plunk (TravisEz13) merged 5 commits into
PowerShell:masterfrom
xtqqczze:set-strictmode
Feb 3, 2020
ConversationCommits (5)ChecksFiles changed
Merged

Set StrictMode version 3.0#11563
Travis Plunk (TravisEz13) merged 5 commits into
PowerShell:masterfrom
xtqqczze:set-strictmode

Conversation

xtqqczze commented Jan 12, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR Summary

Set-StrictMode -Version 3.0

PR Context

PR Checklist

xtqqczze changed the title Specify exact StrictMode version instead of 'Latest' Apply StrictMode version 3.0' Jan 12, 2020
xtqqczze changed the title Apply StrictMode version 3.0' Apply StrictMode version 3.0 Jan 12, 2020
xtqqczze changed the title Apply StrictMode version 3.0 [WIP]Apply StrictMode version 3.0 Jan 13, 2020
xtqqczze mentioned this pull request Jan 13, 2020
Merged
8 tasks
Specify exact StrictMode version instead of 'Latest'
6c95ca4
StrictMode v3.0 in build.psm1
ef32a64 
* Set strict mode to version 3.0
* Fix VariableIsUndefined errors
* Fix PropertyNotFoundStrict errors
StrictMode v3.0 in ci.psm1
e2a92c6
xtqqczze changed the title [WIP]Apply StrictMode version 3.0 Set StrictMode version 3.0 Jan 15, 2020

xtqqczze commented Jan 31, 2020

Copy link
Copy Markdown
Contributor Author

CodeFactor issues are preexisting.

Travis Plunk (TravisEz13) reviewed Jan 31, 2020
View reviewed changes
Comment thread build.psm1 Outdated
Travis Plunk (TravisEz13) reviewed Jan 31, 2020
View reviewed changes
Comment thread build.psm1 Outdated
Travis Plunk (TravisEz13) requested changes Jan 31, 2020
View reviewed changes

Travis Plunk (TravisEz13) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

see comments

ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jan 31, 2020
Travis Plunk (TravisEz13) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Jan 31, 2020
Update build.psm1
e3ead66 
Address @TravisEz13 review

Co-Authored-By: Travis Plunk <travis.plunk@microsoft.com>
ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Feb 1, 2020
Update build.psm1
ddd70bc 
Address @TravisEz13 review

Co-Authored-By: Travis Plunk <travis.plunk@microsoft.com>

xtqqczze commented Feb 1, 2020

Copy link
Copy Markdown
Contributor Author

CodeFactor issues are preexisting.

Travis Plunk (TravisEz13) changed the title Set StrictMode version 3.0 Set StrictMode version 3.0 Feb 3, 2020
Travis Plunk (TravisEz13) merged commit 2014ce6 into PowerShell:master Feb 3, 2020

Travis Plunk (TravisEz13) commented Feb 3, 2020

Copy link
Copy Markdown
Member

xtqqczze Thanks for the contribution

xtqqczze deleted the set-strictmode branch February 4, 2020 23:33

Deleted user (ghost) commented Mar 26, 2020

Copy link
Copy Markdown

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
Set StrictMode version 3.0 (PowerShell#11563)
365654e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Travis Plunk (TravisEz13) TravisEz13 approved these changes
Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
Andrew (anmenaga) Awaiting requested review from anmenaga
Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw

Assignees

Travis Plunk (TravisEz13)

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

7.1.0-preview.1

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL