FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fixes: Build.psm1 by xtqqczze · Pull Request #11572 · PowerShell/PowerShell · GitHub

/ PowerShell Public

Fixes: Build.psm1 - #11572

Merged
Travis Plunk (TravisEz13) merged 5 commits into
PowerShell:masterfrom
xtqqczze:build.psm1
Jan 15, 2020
ConversationCommits (5)ChecksFiles changed
Merged

Fixes: Build.psm1#11572
Travis Plunk (TravisEz13) merged 5 commits into
PowerShell:masterfrom
xtqqczze:build.psm1

Conversation

xtqqczze commented Jan 13, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR Summary

  • Fix typos
  • Refactor code for readability and robustness
  • Fix PSUseCmdletCorrectly rule violations

PR Context

During #11563 issues were uncovered, hence this PR.

PR Checklist

xtqqczze mentioned this pull request Jan 13, 2020
Merged
8 tasks

Travis Plunk (TravisEz13) commented Jan 14, 2020

Copy link
Copy Markdown
Member

Was this tested on Windows PowerShell?

Travis Plunk (TravisEz13) requested changes Jan 14, 2020
View reviewed changes
Comment thread build.psm1
ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jan 14, 2020
Travis Plunk (TravisEz13) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Jan 14, 2020
ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jan 14, 2020
Travis Plunk (TravisEz13) merged commit ba9a7b1 into PowerShell:master Jan 15, 2020
xtqqczze deleted the build.psm1 branch February 4, 2020 23:52

Deleted user (ghost) commented Mar 26, 2020

Copy link
Copy Markdown

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
Code Cleanup for environment data gathering in build.psm1 (PowerShe…
9a300ac 
…ll#11572)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Travis Plunk (TravisEz13) TravisEz13 approved these changes
Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
Andrew (anmenaga) Awaiting requested review from anmenaga
Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw

Assignees

Travis Plunk (TravisEz13)

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

7.1.0-preview.1

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL