| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
It looks like there's an issue in .NET 5 preview1 where we set the main thread name and that somehow gets propagated as the process name on Linux (only) and so tests that check if it's pwsh ends up failing. I'll see about putting in some reasonable workarounds for now and add a pending test to verify the process name. |
Sorry, something went wrong.
There was a problem hiding this comment.
I've looked at the changes so far
Sorry, something went wrong.
|
.NET 5 specifically has improvements to regex, so needed to increase the size of the DOS test |
Sorry, something went wrong.
|
On Windows, pwsh is crashing in a native API call. Opened dotnet/runtime#33703 |
Sorry, something went wrong.
|
Sorry, something went wrong.
Steve Lee (@SteveL-MSFT) is that a bug in .NET? |
Sorry, something went wrong.
|
@danmosemsft The main thread name becoming the process name is a bug in .NET and is understood (dotnet/runtime#33673). That issue isn't blocking as it's currently only affecting tests and I made changes to work around it. The crashing issue (dotnet/runtime#33703) is preventing us from moving to .NET 5. Thanks! |
Sorry, something went wrong.
|
There is already an issues filed for regex DOS tests: #12138 |
Sorry, something went wrong.
Remove assembly from startup validation
|
PoshChan-Bot (@PoshChan) retry macos |
Sorry, something went wrong.
|
Steve Lee (@SteveL-MSFT), successfully started retry of PowerShell-CI-macOS |
Sorry, something went wrong.
|
.NET originally said that the perf improvement was due to optimization, but it's actually due to a bug. I filed an issue to add it back to avoid delaying this PR. |
Sorry, something went wrong.
It's half and half :) The algorithmic complexity improved, in part due to perf improvements, and in part due to a bug fixed in Preview 2 (dotnet/runtime#33409). |
Sorry, something went wrong.
|
🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada: Handy links: |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
PR Summary
Updated associated build files to netcoreapp5.0 and ref assemblies to 5.0-preview.1 where applicable. Updated files.wxs to changes.
PR Checklist