FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Upgrade to .NET 5 Preview 2 by bergmeister · Pull Request #12250 · PowerShell/PowerShell · GitHub

Upgrade to .NET 5 Preview 2 - #12250

Merged
Aditya Patwardhan (adityapatwardhan) merged 8 commits into
PowerShell:masterfrom
bergmeister:net5-preview.2
Apr 8, 2020
Merged

Upgrade to .NET 5 Preview 2#12250
Aditya Patwardhan (adityapatwardhan) merged 8 commits into
PowerShell:masterfrom
bergmeister:net5-preview.2

Conversation

Christoph Bergmeister (bergmeister) commented Apr 3, 2020
edited
Loading

Copy link
Copy Markdown
Contributor

PR Summary

Note: The files.wxs was updated with the suggested file from Start-PSPackage.
The change in Send-MailMessage was due to test failures and probably due to this bug fix in .Net Core: dotnet/runtime#683

PR Context

https://devblogs.microsoft.com/dotnet/announcing-net-5-0-preview-2/

PR Checklist

Copy link
Copy Markdown
Collaborator

Christoph Bergmeister (@bergmeister) You don't update all places. See #12140.

Christoph Bergmeister added 2 commits April 7, 2020 14:20

Copy link
Copy Markdown
Collaborator

Christoph Bergmeister (@bergmeister) Please add

_mSmtpClient.Dispose();

in EndProcessing() method of the Send-MailMessage cmdlet.
I hope it will fix CIs.

Copy link
Copy Markdown
Contributor Author

Good point, I could locally repro and fix it with that. I will add it in a finally block and bring an existing disposal into that finally block as well

…ssing in a finally block and include another disposal in there as well.

Copy link
Copy Markdown
Member

Christoph Bergmeister (@bergmeister) can you fix the CodeFactor issue?

Copy link
Copy Markdown
Contributor Author

Steve Lee (@SteveL-MSFT) OK, done.

Copy link
Copy Markdown
Contributor Author

PoshChan-Bot (@PoshChan) Rerun Mac

Copy link
Copy Markdown
Collaborator

Christoph Bergmeister (@bergmeister), I do not understand the build target(s) Mac; I only allow static, windows, macos, linux, all

Copy link
Copy Markdown
Contributor Author

PoshChan-Bot (@PoshChan) Rerun macos

Copy link
Copy Markdown
Collaborator

Christoph Bergmeister (@bergmeister), successfully started rebuild of PowerShell-CI-macOS

Aditya Patwardhan (adityapatwardhan) merged commit 622eb4c into PowerShell:master Apr 8, 2020
Aditya Patwardhan (adityapatwardhan) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Apr 8, 2020

Copy link
Copy Markdown
Collaborator

Christoph Bergmeister (@bergmeister) Thanks!

Copy link
Copy Markdown

🎉v7.1.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL