FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Resolve issue #2478 by adding -TimeOut to Test-Connection by jpsnover · Pull Request #2479 · PowerShell/PowerShell · GitHub

/ PowerShell Public

Resolve issue #2478 by adding -TimeOut to Test-Connection - #2479

Closed
Jeffrey Snover (jpsnover) wants to merge 2 commits into
masterfrom
jpsnover-patch-1
ConversationCommits (2)ChecksFiles changed
Closed

Resolve issue #2478 by adding -TimeOut to Test-Connection#2479
Jeffrey Snover (jpsnover) wants to merge 2 commits into
masterfrom
jpsnover-patch-1

Conversation

Jeffrey Snover (jpsnover) commented Oct 14, 2016

Copy link
Copy Markdown
Contributor

No description provided.

Microsoft Contribution License Agreements (msftclas) commented Oct 14, 2016

Copy link
Copy Markdown

Hi Jeffrey Snover (@jpsnover), I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.

TTYL, MSBOT;

Mike Richmond (mirichmo) suggested changes Oct 14, 2016
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Management/commands/management/Computer.cs
public Int32 BufferSize { get; set; } = 32;

/// <summary>
/// The following is the definition of the input parameter "BufferSize".

Mike Richmond (mirichmo) Oct 14, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This comment must be updated. It was copied and pasted without modification.

Mike Richmond (mirichmo) commented Oct 14, 2016

Copy link
Copy Markdown
Member

Jeffrey Snover (@jpsnover) Please include test(s) for this change in ...\test\powershell\Modules\Microsoft.PowerShell.Management

Aditya Patwardhan (@adityapatwardhan) and James Truher (@JamesWTruher) Please review

Dongbo Wang (daxian-dbw) commented Oct 14, 2016

Copy link
Copy Markdown
Member

Jeffrey Snover (@jpsnover) PRs should be sent out from a fork instead of from a branch directly pushed to powershell/powershell. That is to make sure powershell/powershell has a minimal number of branches. Could you please close this PR and send it from a fork after addressing the CR comments?

James Truher (JamesWTruher) reviewed Oct 17, 2016
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Management/commands/management/Computer.cs
/// Buffer size sent with the this command. The default value is 32.
/// </summary>
[Parameter]
[ValidateRange((int)1, Int32.MaxValue)]

James Truher (JamesWTruher) Oct 17, 2016

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

1000 [](start = 45, length = 4)

I'm a little worried about this - how did you land on this value? Could the default value be Int32.MaxValue to maintain current behavior? Anyone using this new parameter would likely provide a much smaller number in any case

Jeffrey Snover (jpsnover) Oct 17, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

MAXValue is clearly too large but that is what the API takes and I'm not sure what a reasonable MAX size would be so I juse use the MAXVALUE

Jeffrey Snover (jpsnover) mentioned this pull request Oct 17, 2016
Merged

Jeffrey Snover (jpsnover) commented Oct 17, 2016

Copy link
Copy Markdown
Contributor Author

This was superseded by PR #2492

Dongbo Wang (daxian-dbw) deleted the jpsnover-patch-1 branch October 20, 2016 00:25
Travis Plunk (TravisEz13) added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Review - Waiting on Author labels May 27, 2020
baophucct (baophucct) mentioned this pull request Mar 29, 2024
Open
ajesse11x mentioned this pull request Mar 30, 2024
Open
baophucct (baophucct) mentioned this pull request May 13, 2024
Open
ajesse11x mentioned this pull request May 13, 2024
Open
baophucct (baophucct) mentioned this pull request May 22, 2024
Open
ajesse11x mentioned this pull request May 22, 2024
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
James Truher (JamesWTruher) JamesWTruher left review comments
Mike Richmond (mirichmo) mirichmo requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

James Truher (JamesWTruher)

Labels

Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL