FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

add a timeout to test-connection by jpsnover · Pull Request #2492 · PowerShell/PowerShell · GitHub

add a timeout to test-connection - #2492

Merged
Jason Shirk (lzybkr) merged 1 commit into
PowerShell:masterfrom
jpsnover:jpsnover/Test-ComputerTimeOut
Feb 23, 2017
Merged

add a timeout to test-connection#2492
Jason Shirk (lzybkr) merged 1 commit into
PowerShell:masterfrom
jpsnover:jpsnover/Test-ComputerTimeOut

Conversation

Copy link
Copy Markdown
Contributor

This replaces PR #2479

Hi Jeffrey Snover (@jpsnover), I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

Copy link
Copy Markdown
Collaborator

jeffrey and I spoke about my comments - the current timeout is 1000 ms, so this does not change our current behavior and provides for more flexibility

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

this comment does not seem to apply

Copy link
Copy Markdown
Collaborator

I'd love to see additional tests here -

Describe "test-connection" -Tags @('Feature','Slow' ) {
     It "test-connection respects timeout" {
        $start = [datetime]::now
        Test-Connection -Computer _bad_computer_name_ -Timeout 10000 -ea silentlycontinue
        $end = [datetime]::now
        ($end - $start).TotalSeconds | should BeGreaterThan 10.0
     }
}

something along those lines

Andy Jordan (andyleejordan) commented Oct 17, 2016
edited
Loading

Copy link
Copy Markdown
Member

Your committer email (private@jsnover.com) appears to be connected to the jsnover GitHub account, and not the Jeffrey Snover (@jpsnover) GitHub account you opened the PR from (so the commit doesn't "belong" to Jeffrey Snover (@jpsnover) as far as GitHub is concerned). Do you mean to use this email for you commits, and if so, is it possible to verify it with your current Jeffrey Snover (@jpsnover) GitHub account?

Copy link
Copy Markdown
Contributor Author

Andy Jordan (@andschwa) I've made it so hat private@jsnover.com is the only account connected to my jpsnover github account.
let me know if I need to do anything else

/// The following is the definition of the input parameter "TimeOut".
/// Time-out value in milliseconds. If a response is not received in this time, no response is assumed. The default is 1000 milliseconds.
/// </summary>
[Parameter]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I've never liked this use of ValidateRange - it seems like we should have ValidatePositive and ValidateNonNegative attributes.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.


Back | FazBrowse Home | New Git URL