| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Hi Jeffrey Snover (@jpsnover), I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
Sorry, something went wrong.
|
jeffrey and I spoke about my comments - the current timeout is 1000 ms, so this does not change our current behavior and provides for more flexibility |
Sorry, something went wrong.
There was a problem hiding this comment.
this comment does not seem to apply
Sorry, something went wrong.
|
I'd love to see additional tests here - Describe "test-connection" -Tags @('Feature','Slow' ) {
It "test-connection respects timeout" {
$start = [datetime]::now
Test-Connection -Computer _bad_computer_name_ -Timeout 10000 -ea silentlycontinue
$end = [datetime]::now
($end - $start).TotalSeconds | should BeGreaterThan 10.0
}
}
something along those lines |
Sorry, something went wrong.
|
Your committer email (private@jsnover.com) appears to be connected to the jsnover GitHub account, and not the Jeffrey Snover (@jpsnover) GitHub account you opened the PR from (so the commit doesn't "belong" to Jeffrey Snover (@jpsnover) as far as GitHub is concerned). Do you mean to use this email for you commits, and if so, is it possible to verify it with your current Jeffrey Snover (@jpsnover) GitHub account? |
Sorry, something went wrong.
|
Andy Jordan (@andschwa) I've made it so hat private@jsnover.com is the only account connected to my jpsnover github account. |
Sorry, something went wrong.
| /// The following is the definition of the input parameter "TimeOut". | ||
| /// Time-out value in milliseconds. If a response is not received in this time, no response is assumed. The default is 1000 milliseconds. | ||
| /// </summary> | ||
| [Parameter] |
There was a problem hiding this comment.
I've never liked this use of ValidateRange - it seems like we should have ValidatePositive and ValidateNonNegative attributes.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This replaces PR #2479