Improve warning when additional PowerShell isn't found - #5099
Merged
Andy Jordan (andyleejordan) merged 1 commit intoNov 21, 2024
Merged
Andy Jordan (andyleejordan) merged 1 commit into
Andy Jordan (andyleejordan) merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Andy Jordan (andyleejordan)
requested review from
Justin Grote (JustinGrote) and
Patrick Meinecke (SeeminglyScience)
November 20, 2024 22:04
Andy Jordan (andyleejordan)
force-pushed
the
fix-warning
branch
from
37c4464 to
a7251c8
Compare
November 21, 2024 00:07
Since we added logic which searches for possible intended permutations of the given additional PowerShell path, we needed to make the warning show only if none of the permutations were found. This was accomplished by suppressing it in the first iterator and then yielding it again after the permutations were exhausted with the warning unsuppressed.
Andy Jordan (andyleejordan)
force-pushed
the
fix-warning
branch
from
a7251c8 to
d6d1ad3
Compare
November 21, 2024 00:14
Andy Jordan (andyleejordan)
enabled auto-merge (rebase)
November 21, 2024 00:16
Justin Grote (JustinGrote)
approved these changes
Nov 21, 2024
Justin Grote (JustinGrote)
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
LGTM and tests pass on my machine.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we added logic which searches for possible intended permutations of the given additional PowerShell path, we needed to make the warning show only if none of the permutations were found. This was accomplished by suppressing it in the first iterator and then yielding it again after the permutations were exhausted with the warning unsuppressed.
Justin Grote (@JustinGrote) this bug just really annoyed me...I'm surprised no one reported it yet.