Fix additional PowerShell warning (take two) - #5100
Andy Jordan (andyleejordan) merged 1 commit into
Conversation
Sorry, something went wrong.
Since Show Session Menu always fully enumerates the iterator we needed to move the existence check into the generator. Fortunately the 'exists' method was already idempotent. I'd like this to be cleaner, but at least the tests now make sense (and required a stub fix).
Justin Grote (JustinGrote)
left a comment
There was a problem hiding this comment.
If there's a better approach I cant think of it, since these are filesystem tasks the awaits are actually useful to free up the extension to do other things while the search is happening. Just one item that I see with exists() before I approve.
Sorry, something went wrong.
Justin Grote (JustinGrote)
left a comment
There was a problem hiding this comment.
LOTM (Looks Obtuse to Me)
Sorry, something went wrong.
Justin Grote (JustinGrote)
left a comment
There was a problem hiding this comment.
LOTM (Looks Obtuse to Me)
Sorry, something went wrong.
Unfortunately yes but I didn't think of a cleaner way even over the weekend. At least the tests are less obtuse! |
Sorry, something went wrong.
|
Agreed, me either, was just a joke basically of LGTM because I can't figure out anything better :) |
Sorry, something went wrong.
Since Show Session Menu always fully enumerates the iterator we needed to move the existence check into the generator. Fortunately the 'exists' method was already idempotent. I'd like this to be cleaner, but at least the tests now make sense (and required a stub fix).
This is a follow up to #5099 after further testing.
Justin Grote (@JustinGrote) can you think of a way to simplify this logic?