PEP8 compliant names binding - #83
Merged
jhonabreul merged 13 commits intoApr 11, 2024
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
…al method .net to python
additional: add enums unit tests
11 tasks
Martin-Molinero
approved these changes
Apr 10, 2024
Martin-Molinero
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Awesome work 💪 Minor comments shared
Sorry, something went wrong.
Martin-Molinero
approved these changes
Apr 11, 2024
Comment thread
src/embed_tests/ClassManagerTests.cs
|
|
||
| using var method = pyObj.GetAttr("another_int_property"); | ||
| Assert.IsTrue(method.IsCallable()); | ||
| Assert.AreEqual(654, method.Invoke().As<int>()); |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Nice work 👍
Sorry, something went wrong.
jhonabreul
added a commit
that referenced
this pull request
Jul 9, 2026
…hod (#133) * Fix IndexOutOfRangeException on empty **kwargs call to overloaded method (#132) Calling an overloaded method with an empty kwargs mapping (e.g. obj.Method(arg, **{}), common when forwarding *args/**kwargs from a wrapper) crashed with an unhandled IndexOutOfRangeException in MethodBinder.CheckMethodArgumentsMatch. Since 10e721b (PR #83), the parameter names array is only populated when there are named arguments, but the kwargs code paths only checked the kwargs dictionary for null, so a non-null empty dict indexed into an empty names array. Treat an empty kwargs dict as no keyword arguments, matching Python semantics where f(x, **{}) is equivalent to f(x). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * Update version to 2.0.60 Bump package <Version>, AssemblyVersion/AssemblyFileVersion and the perf-test baseline reference to 2.0.60. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Binding C# style names from C# method/fields/properties to PEP8 conforming names.
Examples: