Add wasm test that input prompt using line not character buffering for stdin - #146
Merged
JohanMabille merged 3 commits intoApr 30, 2026
Merged
JohanMabille merged 3 commits into
JohanMabille merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #146 +/- ##
=======================================
Coverage 88.52% 88.52%
=======================================
Files 62 62
Lines 2884 2884
Branches 358 358
=======================================
Hits 2553 2553
Misses 331 331 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
ianthomas23
force-pushed
the
test-stdin-commit-msg
branch
from
fa51d2a to
4217c4d
Compare
April 28, 2026 15:03
ianthomas23
force-pushed
the
test-stdin-commit-msg
branch
from
4217c4d to
fb0c151
Compare
April 30, 2026 10:48
ianthomas23
force-pushed
the
test-stdin-commit-msg
branch
from
fb0c151 to
c9be559
Compare
April 30, 2026 11:05
ianthomas23
marked this pull request as ready for review
April 30, 2026 11:05
JohanMabille
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The correct handling in WebAssembly of the input prompt used for commit messages (issue #44) was fixed in cockle in jupyterlite/cockle#309. This PR adds a test to confirm the fix by using a backspace character in the input prompt to delete the previous character, thus confirming that stdin is using line buffering not individual character buffering.
The new test is disabled if not running in WebAssembly. It already worked correctly in a manual test but running it via python's subprocess.run doesn't work without us using something more complicated like an input pipe to send the stdin characters, and that approach cannot work in WebAssembly so we'd have to implement some new workaround and it is not worth the effort.
Closes #44.