FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add wasm test that input prompt using line not character buffering for stdin by ianthomas23 · Pull Request #146 · QuantStack/git2cpp · GitHub

  1. QuantStack
  2. git2cpp

Repository navigation

Add wasm test that input prompt using line not character buffering for stdin #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohanMabille merged 3 commits into from
Apr 30, 2026
Conversation 1 Commits 3 Checks 5 Files changed
Merged

Add wasm test that input prompt using line not character buffering for stdin #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d7f45cb
Add wasm test that input prompt using line not character buffering fo…
ianthomas23 Apr 24, 2026
3a52c6b
Set timeout on wasm test CI run
ianthomas23 Apr 27, 2026
c9be559
Update wasm tests in line with latest changes
ianthomas23 Apr 30, 2026
File filter

Filter by extension

Filter by extension .py  (3) .yml  (1) All 2 file types selected
Only manifest files
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
1 change: 1 addition & 0 deletions .github/workflows/test-wasm.yml
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ concurrency:
jobs:
build:
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- name: Checkout
uses: actions/checkout@v6
Expand Down
3 changes: 2 additions & 1 deletion test/conftest_wasm.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ def pytest_ignore_collect(collection_path: pathlib.Path) -> bool:
"test_revlist.py",
"test_revparse.py",
"test_rm.py",
"test_showref.py",
"test_stash.py",
"test_status.py",
"test_tag.py",
Expand All @@ -46,7 +47,7 @@ def run_web_server():
cwd = pathlib.Path(__file__).parent.parent / "wasm/test"
proc = subprocess.Popen(["npm", "run", "serve"], stdout=f, stderr=f, cwd=cwd)
# Wait a bit until server ready to receive connections.
time.sleep(0.5)
time.sleep(1)
yield
proc.terminate()

Expand Down
24 changes: 19 additions & 5 deletions test/test_commit.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

import pytest

from .conftest import GIT2CPP_TEST_WASM


@pytest.mark.parametrize("all_flag", ["", "-A", "--all", "--no-ignore-removal"])
def test_commit(commit_env_config, git2cpp_path, tmp_path, all_flag):
Expand Down Expand Up @@ -33,10 +35,20 @@ def test_commit(commit_env_config, git2cpp_path, tmp_path, all_flag):
assert "mook_file" not in p_status_2.stdout


@pytest.mark.parametrize("commit_msg", ["Added file", ""])
@pytest.mark.parametrize(
"commit_msg_in,commit_msg_out",
[
("Added file", "Added file"),
("", ""),
("ab\x7fc", "ac"), # Check deletes previous character to prove using stdin line buffering
],
)
def test_commit_message_via_stdin(
commit_env_config, git2cpp_path, tmp_path, run_in_tmp_path, commit_msg
commit_env_config, git2cpp_path, tmp_path, run_in_tmp_path, commit_msg_in, commit_msg_out
):
if not GIT2CPP_TEST_WASM and commit_msg_in != commit_msg_out:
pytest.skip("Skip stdin delete test if not using webassembly")

cmd = [git2cpp_path, "init", "."]
p_init = subprocess.run(cmd)
assert p_init.returncode == 0
Expand All @@ -48,9 +60,11 @@ def test_commit_message_via_stdin(
assert p_add.returncode == 0

cmd_commit = [git2cpp_path, "commit"]
p_commit = subprocess.run(cmd_commit, text=True, capture_output=True, input=commit_msg)
p_commit = subprocess.run(
cmd_commit, text=True, capture_output=True, input=commit_msg_in + "\n"
)

if commit_msg == "":
if commit_msg_out == "":
# No commit message
assert p_commit.returncode != 0
assert "Aborting, no commit message specified" in p_commit.stderr
Expand All @@ -66,4 +80,4 @@ def test_commit_message_via_stdin(
assert "commit" in lines[0]
assert "Author:" in lines[1]
assert "Date" in lines[2]
assert commit_msg in lines[4]
assert commit_msg_out in lines[4]
9 changes: 9 additions & 0 deletions test/test_status.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ def test_status_new_file(repo_init_with_commit, git2cpp_path, tmp_path, short_fl
if long_flag != "":
cmd.append(long_flag)
p = subprocess.run(cmd, capture_output=True, cwd=tmp_path, text=True, check=True)
p.stdout = strip_ansi_colours(p.stdout)

if (long_flag == "--long") or ((long_flag == "") & (short_flag == "")):
assert "On branch main" in p.stdout
Expand Down Expand Up @@ -72,6 +73,7 @@ def test_status_add_file(repo_init_with_commit, git2cpp_path, tmp_path, short_fl
cmd_status.append(long_flag)
p_status = subprocess.run(cmd_status, capture_output=True, cwd=tmp_path, text=True)
assert p_status.returncode == 0
p_status.stdout = strip_ansi_colours(p_status.stdout)

if (long_flag == "--long") or ((long_flag == "") & (short_flag == "")):
assert "Changes to be committed" in p_status.stdout
Expand Down Expand Up @@ -144,6 +146,7 @@ def test_status_rename_detection(repo_init_with_commit, git2cpp_path, tmp_path,
cmd_status.append(short_flag)
p = subprocess.run(cmd_status, capture_output=True, cwd=tmp_path, text=True)
assert p.returncode == 0
p.stdout = strip_ansi_colours(p.stdout)

# Should show as renamed, not as deleted + new file
assert "initial.txt -> initial_renamed.txt" in p.stdout
Expand Down Expand Up @@ -223,6 +226,8 @@ def test_status_typechange(repo_init_with_commit, git2cpp_path, tmp_path, short_
p = subprocess.run(cmd_status, capture_output=True, cwd=tmp_path, text=True)

assert p.returncode == 0
p.stdout = strip_ansi_colours(p.stdout)

# Should show typechange in unstaged changes
if short_flag == "-s":
assert " T " in p.stdout
Expand Down Expand Up @@ -295,6 +300,8 @@ def test_status_ahead_of_upstream(
p = subprocess.run(cmd_status, capture_output=True, cwd=clone_path, text=True)

assert p.returncode == 0
p.stdout = strip_ansi_colours(p.stdout)

if short_flag == "-s":
if branch_flag == "-b":
assert "...origin/main" in p.stdout
Expand Down Expand Up @@ -341,6 +348,8 @@ def test_status_with_branch_and_tracking(
p = subprocess.run(cmd_status, capture_output=True, cwd=clone_path, text=True)

assert p.returncode == 0
p.stdout = strip_ansi_colours(p.stdout)

if short_flag == "-s":
assert "## main" in p.stdout # "main" locally, but "master" in the CI
assert "[ahead 1]" in p.stdout
Expand Down
Back | FazBrowse Home | New Git URL