Update test_bytes.py from CPython v3.11.2 - #4746
Merged
youknowone merged 2 commits intoMar 25, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
MegasKomnenos
force-pushed
the
test_bytes
branch
from
3d589c3 to
d48a844
Compare
March 25, 2023 05:01
MegasKomnenos
force-pushed
the
test_bytes
branch
from
d48a844 to
adb8d08
Compare
March 25, 2023 05:02
youknowone
approved these changes
Mar 25, 2023
youknowone
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thank you!
Sorry, something went wrong.
fanninpm
reviewed
Mar 25, 2023
Comment thread
Lib/test/test_bytes.py
Comment on lines
+707
to
+708
| # TODO: RUSTPYTHON | ||
| @unittest.expectedFailure |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
@youknowone This should have been broken out into a separate commit.
Sorry, something went wrong.
fanninpm
reviewed
Mar 25, 2023
Comment thread
Lib/test/test_bytes.py
| s3 = s1.join([b"abcd"]) | ||
| self.assertIs(type(s3), self.basetype) | ||
|
|
||
| @unittest.skip("TODO: RUSTPYHON, Fails on ByteArraySubclassWithSlotsTest") |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
@youknowone This should have been broken out into a separate commit.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4564