Fix issue with cformat converting bytes to string for bytesinner - #4760
Merged
youknowone merged 2 commits intoMar 25, 2023
Merged
Fix issue with cformat converting bytes to string for bytesinner#4760youknowone merged 2 commits into
youknowone merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
youknowone
approved these changes
Mar 25, 2023
youknowone
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
looks good, thank you!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up of the following PR
#4746
It addresses the failing test case for test_mod, where,
b'...%(foo)b...' % {b'foo':b"abc"}caused invalid key error for 'foo'
The cause of this issue was that individual tokens in bytesinner were converted to string before being used for string formatting, but the token being addressed was expected to be in bytes.
It was addressed by making sure that it is treated as bytes.