FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ruff for `Expr` parsing by ShaharNaveh · Pull Request #6207 · RustPython/RustPython · GitHub

/ RustPython Public

ruff for Expr parsing - #6207

Draft
ShaharNaveh wants to merge 1 commit into
RustPython:mainfrom
ShaharNaveh:revert-6206-revert-6124-ruff-unparse
ConversationCommits (1)ChecksFiles changed
Draft

ruff for Expr parsing#6207
ShaharNaveh wants to merge 1 commit into
RustPython:mainfrom
ShaharNaveh:revert-6206-revert-6124-ruff-unparse

Conversation

ShaharNaveh commented Oct 22, 2025

Copy link
Copy Markdown
Contributor

Reverts #6206

coderabbitai Bot commented Oct 22, 2025

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches 🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

ShaharNaveh commented Oct 22, 2025
View reviewed changes
Comment thread Lib/test/test_future_stmt/test_future.py
)
return scope

@unittest.expectedFailure # TODO: RUSTPYTHON; 'a,' != '(a,)'

ShaharNaveh Oct 22, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@youknowone should I open a feature request to ruff team about this? or should we just maintain our own fork of it? I am less in favor of maintaining a fork as it will require us:

  1. maintain a fork
  2. prevents us from publishing a new version to crates.io (unless we push the fork to crates.io)

youknowone Oct 23, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

make a fork, write a feature but ask to merge it before using the fork. split the fork later when rejected. nothing to loose.
because we (and most of open source projects) always don't have enough engineering power for the project, upstreaming is the better choice when possible.

ShaharNaveh Oct 23, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Let's hope that they are fine with this astral-sh/ruff#21041

ShaharNaveh changed the title ruf for Expr uu parsing ruf for Expr parsing Oct 22, 2025
ShaharNaveh changed the title ruf for Expr parsing ruff for Expr parsing Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

youknowone youknowone left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL