FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[ADD] fixed point operations pow and log ALSO fixed point test cases by PRDeving · Pull Request #1765 · SFTtech/openage · GitHub

[ADD] fixed point operations pow and log ALSO fixed point test cases - #1765

Open
PRDeving wants to merge 3 commits into
SFTtech:masterfrom
PRDeving:1543-fixed-point-functions
Open

[ADD] fixed point operations pow and log ALSO fixed point test cases#1765
PRDeving wants to merge 3 commits into
SFTtech:masterfrom
PRDeving:1543-fixed-point-functions

Conversation

PRDeving commented Apr 2, 2025

Copy link
Copy Markdown

Issue

  • Implemented fixed point log function
  • Implemented fixed point pow function
  • Implemented missing testcase for sin
  • Implemented missing testcase for cos
  • Implemented missing testcase for tan

PRDeving mentioned this pull request Apr 2, 2025
11 tasks

heinezen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hey, this is not really what we want with the issue because the point is to have fixed-point values as the results (i.e. not double, float, etc.). We want these operations to be purely fixed-point based, so the game simulation stays deterministic.

I think no one working on this issue has actually understood that yet, so I tried to clarify it in the issue description now :D The code is still useful, so I would merge it, but it still doesn't really solve the issue.

Comment thread copying.md Outdated
Co-authored-by: Christoph Heine <6852422+heinezen@users.noreply.github.com>

PRDeving commented Apr 3, 2025

Copy link
Copy Markdown
Author

Hey, this is not really what we want with the issue because the point is to have fixed-point values as the results (i.e. not double, float, etc.). We want these operations to be purely fixed-point based, so the game simulation stays deterministic.

I think no one working on this issue has actually understood that yet, so I tried to clarify it in the issue description now :D The code is still useful, so I would merge it, but it still doesn't really solve the issue.

Makes sense, I just sticked to the previous iterations, I'll redo all operators to comply with it

heinezen added improvement Enhancement of an existing component lang: c++ Done in C++ code area: util Utilitis and data structures labels May 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: util Utilitis and data structures improvement Enhancement of an existing component lang: c++ Done in C++ code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL