| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Reset IsTeleporting and ExplicitSet after invoking OnAuthorityPushTransformState so these values are preserved for user script. Automatically adjust InLocalSpace when spawning a NeworkObject based on the NetworkObject's current parented status when SwitchTransformSpaceWhenParented is enabled.
…e-forcing-updates-localspace
…calspace' of https://github.com/Unity-Technologies/com.unity.netcode.gameobjects into fix/networktransform-autoswitchspace-forcing-updates-localspace
There was a problem hiding this comment.
Left suggestions on the smaller changes - have pushed a commit with changes to the larger new additions to the NetworkTransform page, mostly just trying to improve clarity and reduce verbiage.
This page is getting very long, might break it up at some point, but will do that in a separate PR.
Sorry, something went wrong.
NetworkSpawnManager: Relative to spawning only, process deferred messages after post spawn. NetworkTransform: Synchronize the SwitchTransformSpaceWhenParented flag when it changes on the authority side. Perform an early check in CheckForStateChange for changes to SwitchTransformSpaceWhenParented. Apply changes to SwitchTransformSpaceWhenParented when processing a state update on non-authority instance.
…calspace' of https://github.com/Unity-Technologies/com.unity.netcode.gameobjects into fix/networktransform-autoswitchspace-forcing-updates-localspace
Co-authored-by: Amy Reeve <amy.reeve@unity3d.com>
…orm.cs Co-authored-by: Amy Reeve <amy.reeve@unity3d.com>
…orm.cs Co-authored-by: Amy Reeve <amy.reeve@unity3d.com>
…orm.cs Co-authored-by: Amy Reeve <amy.reeve@unity3d.com>
…e-forcing-updates-localspace
A complete refactoring of how parenting is handled when NetworkTransform.SwitchTransformSpaceWhenParented is enabled to provide a complete 1:1 match of (n) back-to-back parenting actions and/or many parenting actions that occur over several frames. This preserves the order of operations, sends 1 full state update plus an added parenting directive per action immediately, and then upon receiving the non-authority instances will apply the parenting, transform the local values and interpolators' queued entries between transform spaces (world to local, local to world, or local to local).
|
/ci ngo |
Sorry, something went wrong.
|
/ci ngo |
Sorry, something went wrong.
More hidden white spaces...
|
/ci ngo |
Sorry, something went wrong.
|
/ci ngo |
Sorry, something went wrong.
…e-forcing-updates-localspace
…e-forcing-updates-localspace
…e-forcing-updates-localspace
…e-forcing-updates-localspace
There was a problem hiding this comment.
This PR was genuinely a joy to review ![]()
So many nice things in here I couldn't begin to list them all. Most of my comments are small nit picks. Overall this looks so clean and nice and wonderful I don't even have enough words to say how much I like it.
Sorry, something went wrong.
…orm.cs Co-authored-by: Emma <emma.mcmillan@unity3d.com>
…etworkobject.md Co-authored-by: Emma <emma.mcmillan@unity3d.com>
Co-authored-by: Emma <emma.mcmillan@unity3d.com>
Co-authored-by: Emma <emma.mcmillan@unity3d.com>
Co-authored-by: Emma <emma.mcmillan@unity3d.com>
HelpURL tests now check to see if the document exists before failing if it can't be loaded from the latest documentation update. Adjusted the HelpUrls base portions of the URL so they are internal.
Using System.IO.File. Migrating into the testproject's runtime tests. Encapsulating within UNITY_EDITOR define. Removed the iPhone platform exclusion.
Co-authored-by: Emma <emma.mcmillan@unity3d.com>
…ater.cs Co-authored-by: Emma <emma.mcmillan@unity3d.com>
|
/test_plan |
Sorry, something went wrong.
Test Plan
Summary of Changes & Risk Assessment Summary of ChangesThis PR addresses critical synchronization issues in NetworkTransform, specifically when SwitchTransformSpaceWhenParented is enabled. It ensures that parenting/re-parenting actions (even multiple times in a single frame) are correctly synchronized to non-authority instances. Additionally, it changes the default NetworkDelivery for most core messages to ReliableFragmentedSequenced to preserve order of operations and modifies NetworkShow to force NetworkVariable synchronization before object creation. Significant documentation updates for NetworkRigidbody and NetworkTransform are also included. Risk Assessment
Test Scenarios Functional Testing
Regression Testing
Edge Cases
💡 This test plan updates automatically when /test_plan is run on new commits. If you have any feedback, please reach out in #ai-qa 🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr |
Sorry, something went wrong.
|
/test_review |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Purpose of this PR
This PR resolves the issue where setting SwitchTransformSpaceWhenParented to true and then setting InLocalSpace to true will force the motion authority to continually send updates each tick (whether there is a delta or not).
Jira ticket
MTTB-1584
fix: #3653
fix: #3646
fix: #3645
Changelog
Documentation Included
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Automated tests:
Does the change require QA team to:
If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Backports
This is an NGO v2.x.x specific issue. No backport is required.